Subject: Re: commit -- fix convertToDimensionString
From: Paul Egli (pegli@sourcegear.com)
Date: Tue Aug 08 2000 - 14:56:20 CDT
At 11:25 AM 8/6/00 +0800, Bruce Pearson wrote:
>fix UT_convertToDimensionString so it actually does the conversion.
>
>ut_units.h
>ut_units.cpp
>
This was a bug fix for #642 if I'm not mistaken.
There was some discussion of bug 642 on the list last month:
http://www.abisource.com/mailinglists/abiword-dev/00/July/0346.html
Now take a look at bug 910:
http://www.abisource.com/bugzilla/show_bug.cgi?id=910
A while back, I had marked bug 910 as Works-For-Me in bugzilla. Today I
casually double-checked it, only to find that it had returned.
It seems to me that besides fixing bug 642, this commit also reintroduced
#910.
Further investigation showed that bugs 642 and 910 also flip-flopped with
Justin's "vector images" commit:
0.7.10 - 642 fixed, 910 broken
After Justin's "vector images" commit - 642 broken, 910 fixed
After your "convertToDimensionString" commit - 642 fixed, 910 broken
(In 0.7.7, both seemed to work okay, but that was 8 months ago...)
Hopefully we can get a fix into CVS that will correctly do the unit
conversions required by both of these bugs (and any other potential problems).
-Paul Egli
This archive was generated by hypermail 2b25 : Tue Aug 08 2000 - 14:55:21 CDT