Subject: PATCH: Insert Symbol (2)
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Tue Feb 29 2000 - 22:32:31 CST
Here is the second version of the insert_symbol patch.
I used diff -Naur src src-symbol > symbol.patch
to create it from a 2 hour old abi update. It has been gzipped otherwise
it would have been 220 Kbytes!
It applied cleanly and built the gnome and unix versions from the patch.
I've attempted to stub all the other platforms, have updated the
platform-specific Makefiles and included xap_****Dlg_Insert_Symbol in the
platform specific DeclareDialog() functions. It will probabally fail to
compile on the other platforms though :-(.
Paul Rohr wrote:
>3. In the s_InsertSymbolDlg edit method, it looks like you're calling a
>View-level method to get the current font, only to pass it right back to
>another View method when you insert the symbol. Is that extra
>information
>needed outside the view, or can you just omit it from the downcall API
>and
>just do the lookup internally as needed?
I followed what I thought was a convention in ap_EditMethods.cpp. In
retrospect I kind of like this approach as it makes it easy and
transperent to connect s_InsertSymbolDlg to different signals - like
either a ctrl- keyboard binding or a button on the toolbar.
>4. Style note: it should probably be FV_View::insertSymbol() instead --
>we tend to not capitalize the verb at the beginning of method names.
I have removed this code from fv_View and put in back in ap_EditMethods. I
only put it there because I thought I would need to access private member
functions in fv_view to work around the Backspace bug I reported in the
first post. In response to Bob Sievers I decided that "Insert_Symbol"
should not work around this bug. (Not that I have a work around anyway.)
Cheers
Martin Sevior
This archive was generated by hypermail 2b25 : Tue Feb 29 2000 - 22:32:40 CST
