Subject: commit -- Re: Win32 Word Count, modeless dialogs, keyboard input, etc
pegli@sourcegear.com
Date: Mon Jul 03 2000 - 15:05:34 CDT
I've committed Thomas Briggs's patch "wordcount3.diff" It works great
except for a few minor complaints:
(1) If the Word Count dialog is already open, selecting it from the menu
does not bring it to the foreground.
(2) All non-zero values for "Seconds between updates" use a one-second
interval.
(3) The title of the Word Count dialog box can be a little confusing. I
think it should include "Word Count - " and the filename, but without the
path. Also, when the filename is too long and has to be cut short, it
should get cut it off the right side as to be consistent with the document
window and because the ".abw *" would be first to go, so you could see more
of the actual file name. It should also use more of the available space in
the title bar; right now it cuts the title short, and there's still a bunch
of room left at the end.
I might log these in bugzilla Wednesday morning.
-Paul Egli
Patch from Thomas Briggs:
1. Makes it possible for modeless dialogs to receive keyboard input on Win32
2. Implements the Word Count dialog
3. Fixes the Insert Symbol dialog to accept keyboard input
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: af/xap/win/xap_Win32Dlg_Insert_Symbol.h af/xap/xp/xap_Dialog.h
CVS: wp/ap/win/ap_Win32App.cpp wp/ap/win/ap_Win32App.h
CVS: wp/ap/win/ap_Win32Dialog_WordCount.cpp
CVS: wp/ap/win/ap_Win32Dialog_WordCount.h
CVS: wp/ap/win/ap_Win32Res_DlgWordCount.rc2
CVS: ----------------------------------------------------------------------
At 11:24 AM 7/1/00 -0400, Thomas Briggs wrote:
>
> The attached patch accomplishes the following:
>
> 1. Makes it possible for modeless dialogs to receive keyboard input on
>Win32. Unfortunately this requires an ugly hack to xap_DialogModeless
>(suggestions on a better implementation are welcome). Thanks to Hubert
>Figuiere for the help in solving this little doozy.
> 2. Implements the Word Count dialog, with all problems I was previously
>having solved (thanks mainly to #1). I believe that it's now ready to
>face the Bob/Paul Egli challenge. :)
> 3. Fixes the Insert Symbol dialog to accept keyboard input (you can't
>select the symbol via the keyboard, but at least the tab key works and you
>can change the font).
>
> On a somewhat related note, I have two questions:
> 1. I've noticed some odd behaviour in the way that modeles dialogs
>work. If you open a modeless dialog, then go back to the document, then
>select (for example) Tools | Word Count from the menu bar, the Word Count
>dialog is updated but the document retains the input focus. It's
>specifically coded this way in the unix version, so I mimicked it in the
>Win32 version, but I have to ask: is this really the desired behaviour?
>Should I have to click on the dialog with the mouse in order to give it
>the input focus?
>
> 2. What's the rule for when modeless dialogs should stay on top of the
>documents? The Word Count dialog, for example, falls behind the document
>once it loses focus (I mimicked the unix behaviour here as well), but the
>Insert Symbol dialog stays on top. Is this by design? Accidental? Is
>there a rule we should be following in this regard?
>
> In case anybody's actually read through this whole thing, I'm going to
>throw out one more thought while I'm at it. I must say that I'm really
>impressed with the AbiWord codebase - I'm no junior programmer, but for me
>to be able to jump in and with relatively little effort implement the
>stuff I have says a lot about the code that's already there and the people
>who wrote it.
>
> -Tom
>
>
>Attachment Converted: "c:\program files\eudora\attach\wordcount3.diff"
>
This archive was generated by hypermail 2b25 : Mon Jul 03 2000 - 15:04:08 CDT