Subject: [PATCH] xap_dialog cleanup
From: Hubert Figuiere (hfiguiere@teaser.fr)
Date: Fri Jul 07 2000 - 01:54:11 CDT
Here is a patch the clean up the XAP dialog code.
What does it do:
In xap_Dialog.h we have in class XAP_Dialog_Modeless:
// not pure functions. Unix doesn't need to implement these functions
virtual void notifyActiveFrame(XAP_Frame *pFrame) {}
virtual void notifyCloseFrame(XAP_Frame *pFrame) {}
But whether we should implement this is dependant for the platform, I think
those 2 methods should be pure virtual and the platform implementation
should choose to make implement it with and empty body if they don't need it.
This gives:
virtual void notifyActiveFrame(XAP_Frame *pFrame) = 0;
virtual void notifyCloseFrame(XAP_Frame *pFrame) = 0;
This would just make the port to other platform easier (because the compiler
would told you about this).
I have modified UNIX version of implementation to conform to this. This
patch may break the BeOS, QNX and Windows build.
Hub
This archive was generated by hypermail 2b25 : Fri Jul 07 2000 - 01:52:44 CDT