Subject: commit -- Re: StringPool
From: sam th (sam@uchicago.edu)
Date: Thu Jul 20 2000 - 23:34:57 CDT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Sun, 16 Jul 2000, Allan Clark wrote:
> Hi
> I'm pretty new here and I'm looking through the source code to
> familiarize myself with the code.
> I think I might be wrong here but have a look at the implementation for the
> UT_StringPool class, in abi/src/af/util/xp/ut_pool.cpp
> in here it has a function called AddBucket() which adds a new bucket with
> space for 1024 chars, it also has a function AddString(const char *p), it
> checks to see if there is enough space in the Bucket at the head of the list
> for the given string to be added to, if not it creates a new Bucket using
> the aforementioned AddBucket and therefore with space for 1024 chars, now
> what if the string to be added is longer than 1024 chars? will this not
> cause it too crash?
Astute readers (unlike me) will notice that I just committed this patch
accidentally. No matter, it works just fine. Added Allan to the CREDITS.
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE5d9Lzt+kM0Mq9M/wRAhkSAJ9dOlnHtQ5uF6B7oMkCUw/HCddH2gCcDLMH
avAU2iQLhi7rQ7sDorlwByY=
=gx2J
-----END PGP SIGNATURE-----
This archive was generated by hypermail 2b25 : Thu Jul 20 2000 - 22:29:21 CDT