Subject: Re: [RFC2] new findPointCoords implementation (and bug triage(sp?))
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Sun Jun 04 2000 - 23:36:38 CDT
On Sat, 3 Jun 2000, Jesper Skov wrote:
>
> Martin> Hi Jesper, I gunzipped your patch and looked through the
> Martin> code. It looks like it will work but unfortunately I can't
> Martin> test it till Monday. I'm looking forward to trying it out
> Martin> though. Those cursor movement bugs have been bothering me for
> Martin> a long time. I also know where they are so I'll be sure to see
> Martin> if you've fixed them :-)
>
> Martin,
>
> I'm glad you didn't get to test it. It didn't handle margins properly.
>
> The patch below has been tested better. I cannot find any problems
> with it.
>
> It fixes the below Bugs (i.e., I could reproduce with a pre-patched
> build, but not with the pathed build):
> 852, 851, 841, 823, 449, 448,
>
> Tested bugs which could be related to the changes, but are still failing:
> 800, 778, 777, 406
>
> Possibly related, but didn't have time to test (or didn't have enough
> info for me to bother trying to reproduce):
> 751
>
> Bugs that are probably fixed (could not reproduce with either version):
> 739
>
>
> Other observed bugs:
> (851 related): I loaded BillOfRights.abw, reduced margins and pressed
> ctrl-return between two pages. Didn't seem to have an effect other
> than adding a newline.
>
> There's the odd "fv_View.cpp: line x, iNewPoint != iOldPoint"
> assertions.
>
> Cheers,
> Jesper
>
OK I'm no Bob Seivers but your new code handles cursor motion very well.
Much better than old abi. I especially like superscript/subscripting now.
The cursor always tells you what size the character is and where the
inserted character will go.
I couldn't get Sam's segfaults. Great job Jesper! You succeded where I
gave up :-)
Cheers
Martin
This archive was generated by hypermail 2b25 : Sun Jun 04 2000 - 23:37:05 CDT