Subject: Can someone approve this patch?
From: Robert Sievers (bob@abisource.com)
Date: Thu May 18 2000 - 22:41:29 CDT
The following came into patches a while ago, and I really am not sure
whether this is the appropriate fix. Can someone verify this would be ok
to apply and commit if appropriate?
-----------------
From: Peter Haight <peterh@sapros.com>
Sender: peterh@wartch.sapros.com
I'm on FreeBSD 4.0. This fixes a problem where the margin was being drawn
outside the window. It is possible that this is some sort of GTK bug, but
this fixes my problem and it makes sense not to draw the margin if it cannot
be seen.
? margin-patch.patch
Index: fv_View.cpp
===================================================================
RCS file: /cvsroot/abi/src/text/fmt/xp/fv_View.cpp,v
retrieving revision 1.253
diff -u -u -r1.253 fv_View.cpp
--- fv_View.cpp 2000/04/15 12:35:13 1.253
+++ fv_View.cpp 2000/04/30 00:30:02
@@ -3949,7 +3949,10 @@
m_pG->drawLine(adjustedLeft, adjustedBottom, adjustedLeft, adjustedTop);
// fill to right of page
- m_pG->fillRect(clrMargin, adjustedRight + 1, adjustedTop,
m_iWindowWidth - (adjustedRight + 1), iPageHeight + 1);
+ if (m_iWindowWidth - (adjustedRight + 1) > 0)
+ {
+ m_pG->fillRect(clrMargin, adjustedRight + 1, adjustedTop,
m_iWindowWidth - (adjustedRight + 1), iPageHeight + 1);
+ }
// fill separator below page
m_pG->fillRect(clrMargin, adjustedLeft, adjustedBottom + 1,
m_iWindowWidth - adjustedLeft, fl_PAGEVIEW_PAGE_SEP);
Robert Sievers
Open Source Evangelist
This archive was generated by hypermail 2b25 : Thu May 18 2000 - 22:43:49 CDT