Subject: Summary (was Re: asserts and pagebreaks)
From: sam th (sam@bur-jud-118-039.rh.uchicago.edu)
Date: Mon May 22 2000 - 12:31:29 CDT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
OK - here's a summary, as much for me as for anyone else
Currently discussed problems -
1)
open abiword
enter "1234"
cursor left twice
break page (control-return)
(optional left)
**** (1) Assert ****
**** (1) FP_RUN_NOT != containsOffset(iOffset) at fp_Run.cpp:1222 ****
**** (1) Continue ? (y/n) [y] : n
This was orginally mentioned by Jesper.
He proposed a patch in his origninal message. Mike mentioned that it
didn't happen for him, so this may be a linux problem. He attached his
working copy of fl_BlockLayout::findPointCoords which is where he thought
the problem lay. Jesper then mentioned that Mike's code still had the
bug. Mike then proposed the fix
- - if (nextRun) [nextRun->lookupProperties(); and so on]
+ if (nextRun && nextRun->canContainPoint())
2) Bug 760
Jesper provided a patch for this bug. He felt that this was the same bug
as 1) above, but I disagreed, and posted reasons why. Martin claimed that
the segfault that I mentioned didn't happen for him in non-debug builds.
In a new thread, mike then suggested adding a call to
_insertFakeTextRun().
Finally, in yet a fourth thread, mike suggested adding the following
patch.
- --- fp_TextRun.cpp Thu May 18 11:01:12 2000
+++ \AbiWord\abi\src\text\fmt\xp\fp_TextRun.cpp Mon May 22 14:23:34 2000
@@ -350,6 +350,10 @@
{
pos = m_pBL->getPosition() + m_iOffsetFirst + m_iLen;
+ // TODO Is this assumption, if we're at or over the right edge
+ // bEOL == UT_TRUE, correct?!
+ bEOL = UT_TRUE;
+
UT_ASSERT(bEOL == UT_TRUE || bEOL == UT_FALSE);
UT_ASSERT(bBOL == UT_TRUE || bBOL == UT_FALSE);
This would seem to fix yet a third assert (one that I have seen before).
In summary, the current issues are:
1- Are problems 1 and 2 above the same (I don't think so).
2- How to fix problems?
3- The patch that mike proposed to fix the assert in fp_TextRun.cpp:354
Hope this helps someone besides me.
sam th
sam@uchicago.edu
http://sam.rh.uchicago.edu
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE5KW7zt+kM0Mq9M/wRAq+qAJ4nK2nKR4pJQ1M4ztZDPYD+bCJccQCgtULX
RP/QQiGYIti4BFkdwUkx678=
=EGHN
-----END PGP SIGNATURE-----
This archive was generated by hypermail 2b25 : Mon May 22 2000 - 12:31:32 CDT