Re: Win32 0.7.12 fix


Subject: Re: Win32 0.7.12 fix
From: Vlad Harchev (hvv@hippo.ru)
Date: Fri Nov 10 2000 - 06:10:04 CST


On Fri, 10 Nov 2000, Mike Nordell wrote:

> Finally!
>
> In spell/newMain.c there is a conditional check for __GLIBC__. Now, I don't
> know why this check is here, but if I replace

 glibc doesn't know "UCS-2-INTERNAL", only "UCS-2". I've added that check.

> #ifndef __GLIBC__
> # define UCS_2_INTERNAL "UCS-2-INTERNAL"
> #else
> # define UCS_2_INTERNAL "UCS-2"
> #endif
>
> with
>
> #if !defined(__GLIBC__) && !(defined(WIN32) || defined(_WIN32))
> # define UCS_2_INTERNAL "UCS-2-INTERNAL"
> #else
> # define UCS_2_INTERNAL "UCS-2"
> #endif
>
> Win32 spell-checking works (again).
>
> Now it doesn't seem totally unreasonable to think that this check should
> really be for big/little-endian platforms. Am I completely wrong?

 With automatic detection of iconv byte order all these conditionals are not
needed. Just
# define UCS_2_INTERNAL "UCS-2"
 unconditionally and it should work. It should fix spellchecking on all
platforms then. Please test it.

> /Mike
>

 Best regards,
  -Vlad



This archive was generated by hypermail 2b25 : Fri Nov 10 2000 - 06:29:05 CST