Quick patch

Subject: Quick patch
From: John L . Clark (jlc6@po.cwru.edu)
Date: Thu Oct 05 2000 - 14:19:31 CDT

• sorted by: [ date ] [ thread ] [ subject ] [ author ]
• Next message: Paul Egli: "Slight build farm trouble"
• Previous message: Thomas Briggs: "red in tinderbox"

This patch removes a repeated #include from
abi/src/wp/ap/unix/ap_UnixDialogFactory.cpp. I'm not entirely sure why
it was there, but it was breaking my build. This is weird, given that
this file was last updated on July 6th (or so sayeth Bonsai). That
being said, it appears to me that my fix is more of a hack. Even more,
the included file (abi/src/wp/ap/unix/ap_UnixDialog_All.h) was causing
bizarre linker errors, but in the file itself it claims that it must be
included more than once (why?).

So, needless to say, I'm a bit confused about what actually is wrong,
and why my fix IS a fix. Help?

And the relevant sections of my `make` output are:

Linking dynamic /home/john/In_progress/abisource/abi/src/Linux_2.2.12-1_i386_DBG/bin/AbiWord_d
/home/john/In_progress/abisource/abi/src/Linux_2.2.12-1_i386_DBG/obj/libAbiWPAp.a(ap_UnixDialogFactory.o): In function `global constructors keyed to AP_UnixDialogFactory::AP_UnixDialogFactory(XAP_App *)':
/home/john/In_progress/abisource/abi/src/wp/ap/unix/ap_UnixDialogFactory.cpp:31: undefined reference to `AP_UnixDialog_Tab::static_constructor(XAP_DialogFactory *, int)'
/home/john/In_progress/abisource/abi/src/wp/ap/unix/ap_UnixDialogFactory.cpp:31: undefined reference to `AP_UnixDialog_Tab::static_constructor(XAP_DialogFactory *, int)'
collect2: ld returned 1 exit status
make[4]: *** [/home/john/In_progress/abisource/abi/src/Linux_2.2.12-1_i386_DBG/bin/AbiWord_d] Error 1
make[4]: Leaving directory `/home/john/In_progress/abisource/abi/src/wp/main/unix'
make[3]: *** [build] Error 2
make[3]: Leaving directory `/home/john/In_progress/abisource/abi/src/wp/main'
make[2]: *** [build] Error 2
make[2]: Leaving directory `/home/john/In_progress/abisource/abi/src/wp'
make[1]: *** [build] Error 2
make[1]: Leaving directory `/home/john/In_progress/abisource/abi/src'
make: *** [compile] Error 2

And then removing that #include allows it to build again. This is on
the most recent cvs tree.

John L. Clark

• text/plain attachment: ap_UnixDialogFactory.diff

• Next message: Paul Egli: "Slight build farm trouble"
• Previous message: Thomas Briggs: "red in tinderbox"

This archive was generated by hypermail 2b25 : Thu Oct 05 2000 - 14:19:36 CDT