Subject: Re: patch: ignored word maintenance
From: sam th (sam@uchicago.edu)
Date: Thu Sep 07 2000 - 00:05:56 CDT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Mon, 4 Sep 2000, WJCarpenter wrote:
> This patch, against 090100 sources, fixes up various things in the
> maintenance of ispell's ignored words list.
>
> 1. All *alloc()/free() sets changed to new/delete. Also eliminated
> the need for memory allocation for scratch buffers for most common
> cases. Ignored word maintenance isn't exactly performance critical,
> but every little bit helps.
>
> 2. The signature of enumIgnores() was changed because the signature
> it had would have been ineffective. (enumIgnores() was not previously
> called, but is called now for a UT_DEBUGMSG() in the AD_Document
> destructor.)
>
> 3. Fixed a sort of interesting problem about duplicate entries. When
> you "ignore all" on some word, spell-check queues all the blocks in a
> document for re-spell-checking. That's done in the background. For a
> long document, it's easy to do "ignore all" on another instance of the
> same word before the squiggle is removed. That leads to an attempt at
> adding a duplicate entry to the hash table, and that leads to an
> assert. The assert looks harmless to me, but since hash tables are
> used all over the place, I didn't remove it. Instead, I made ignored
> word maintenance check for an entry before trying to add it.
Committed
Committed ignored word fixes from Bill Carpenter.
CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: src/af/xap/xp/xad_Document.cpp src/af/xap/xp/xad_Document.h
CVS: ----------------------------------------------------------------------
sam th
sam@uchicago.edu
http://www.abisource.com/~sam/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.1 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE5tyI3t+kM0Mq9M/wRAutEAKDPmsCYCfShfUGfr4erw4ziUoUTxACgkdQ9
KmZSPmQ+zTmJu4VuW8gaEYE=
=gDYI
-----END PGP SIGNATURE-----
This archive was generated by hypermail 2b25 : Wed Sep 06 2000 - 22:54:27 CDT