Subject: Re: commit -- fix (Re: commit: New Lists Implementation.)
From: sam th (sam@uchicago.edu)
Date: Fri Sep 15 2000 - 08:56:05 CDT
On Fri, 15 Sep 2000, Martin Sevior wrote:
>
>
> On Fri, 15 Sep 2000, sam th wrote:
>
> > On Fri, 15 Sep 2000, Martin Sevior wrote:
> >
> > > Hi everyone,
> > > here is the new lists implementation. It will probabally break
> > > windows and Beos builds.
> > >
> >
> > Committed a quick fix. Remember, all const variables must be initialized
> > at the time of declaration.
>
> You beat me to it by 5 minutes. I still think it will fail later on
> Windows though. :-(
>
It did indeed fail on windows. I believe that the attached patch will fix
the problem, but would appreciate it if someone could check that for me.
It does still compile on Unix. (This doesn't break your code, does it
Martin?)
Index: src/text/fmt/xp/fp_Line.cpp
===================================================================
RCS file: /cvsroot/abi/src/text/fmt/xp/fp_Line.cpp,v
retrieving revision 1.74
diff -u -r1.74 fp_Line.cpp
--- src/text/fmt/xp/fp_Line.cpp 2000/09/15 06:51:59 1.74
+++ src/text/fmt/xp/fp_Line.cpp 2000/09/15 13:54:59
@@ -822,11 +822,11 @@
if( i <= 0 )
{
fp_Run * pRun = getBlock()->getFirstRun();
- return (const) pRun;
+ return pRun;
}
else
{
- return ((const fp_Run*) m_vecRuns.getLastItem());
+ return ((fp_Run*) m_vecRuns.getLastItem());
}
}
sam th
sam@uchicago.edu
http://www.abisource.com/~sam
This archive was generated by hypermail 2b25 : Fri Sep 15 2000 - 08:56:10 CDT