Re: commit -- autoconf stuff


Subject: Re: commit -- autoconf stuff
jskov@zoftcorp.adsl.dk
Date: Sun Apr 15 2001 - 04:01:09 CDT


>>>>> "Sam" == Sam TH <sam@uchicago.edu> writes:

Sam> - added dependecies between the libraries, so things get rebuilt
Sam> properly.

This must some specific build directory layout. The all: rule in the
top-level makefile:

all: expat wv psiconv

expat:
        (cd ../expat; ./configure --enable-shared=no; make)

wv:
        (cd ../wv; ./configure --enable-shared=no; make);

psiconv:
        (cd ../psiconv; ./configure --enable-shared=no; make)

will try to build expat, wv, and psiconv, but relative to the build
directory. Only, if you don't have your build directory located at the
same level as the sources, you effecttively get an infinite loop out
of the above.

First of all you should probably use && instead of ; to terminate on
failures.

Second, wv should use --with-exporter, if I'm not mistaken.

Finally, shouldn't these rules take priority over the abiword build
rule? I mean, building the support libs after the main build would
have failed isn't very useful :) But I don't know how to do that -
and with the above suggested changes (see patch below), the support
libs begin building as well if I do 'make -j' in the build tree,
messing up everything.

So what am I missing?

Jesper

Index: GNUmakefile.am
===================================================================
RCS file: /cvsroot/abi/GNUmakefile.am,v
retrieving revision 1.3
diff -u -5 -r1.3 GNUmakefile.am
--- GNUmakefile.am 2001/04/15 03:25:37 1.3
+++ GNUmakefile.am 2001/04/15 09:01:53
@@ -4,17 +4,17 @@
 MAINTAINERCLEANFILES=GNUmakefile
 
 all: expat wv psiconv
 
 expat:
- (cd ../expat; ./configure --enable-shared=no; make)
+ (cd $(top_srcdir)/../expat && ./configure --enable-shared=no && make)
 
 wv:
- (cd ../wv; ./configure --enable-shared=no; make);
+ (cd $(top_srcdir)/../wv && ./configure --enable-shared=no --with-exporter && make);
 
 psiconv:
- (cd ../psiconv; ./configure --enable-shared=no; make)
+ (cd $(top_srcdir)/../psiconv && ./configure --enable-shared=no && make)
 
 clean:
         make -C src clean
         rm -f src/wp/ap/xp/ap_wp_sidebar.cpp
         rm -f src/wp/ap/xp/ap_wp_splash.cpp



This archive was generated by hypermail 2b25 : Sun Apr 15 2001 - 04:02:44 CDT