Re: commit: fv_View.cpp

Subject: Re: commit: fv_View.cpp
From: Adrian Phillips (adrianp@powertech.no)
Date: Fri Dec 21 2001 - 05:50:25 CST

• sorted by: [ date ] [ thread ] [ subject ] [ author ]
• Next message: Bryce Nesbitt: "Re: On the Road to version 1.0"
• Previous message: Savant shanti: "Other natural languages"
• In reply to: Tomas Frydrych: "commit: fv_View.cpp"
• Next in thread: Dom Lachowicz: "Re: commit: fv_View.cpp"
• Reply: Adrian Phillips: "Re: commit: fv_View.cpp"
• Reply: Dom Lachowicz: "Re: commit: fv_View.cpp"

>>>>> "Tomas" == Tomas Frydrych <tomas@frydrych.uklinux.net> writes:

Tomas> fixed a bug in gotoTarget: bookmark which caused SIGSEGV
Tomas> for incomplete bookmarks (can happen when importer fauls
Tomas> up).

Another problem with fv_View.cpp when compiling without DEBUG :-

fv_View.cpp:
fv_View.cpp: In method `PT_DocPosition FV_View::_getDocPosFromPoint(unsigned int, _FVDocPos, bool = true)':
fv_View.cpp:1197: warning: unused variable `bool bRes'
fv_View.cpp:1249: warning: unused variable `bool bRes'
fv_View.cpp:1302: warning: unused variable `bool bRes'
fv_View.cpp: In method `UT_Error FV_View::_deleteBookmark(const char *, bool, PT_DocPosition &, PT_DocPosition &)':
fv_View.cpp:8223: warning: `class fp_Run * pRun' might be used uninitialized in this function
fv_View.cpp: In method `UT_UCSChar * FV_View::_lookupSuggestion(fl_BlockLayout *, fl_PartOfBlock *, unsigned int)':
fv_View.cpp:9076: warning: unused variable `bool bRes'
fv_View.cpp: In method `void FV_View::cmdContextIgnoreAll()':
fv_View.cpp:9191: warning: unused variable `bool bRes'
fv_View.cpp: In method `void FV_View::cmdContextAdd()':
fv_View.cpp:9227: warning: unused variable `bool bRes'
fv_View.cpp: In method `bool FV_View::insertEndnote()':
fv_View.cpp:10663: `FPFIELD_endnote_ref' undeclared (first use this function)
fv_View.cpp:10663: (Each undeclared identifier is reported only once
fv_View.cpp:10663: for each function it appears in.)
make[4]: *** [/usr/local/src/abiword/abi/src/Linux_2.2.20pre11_i386_GNOME/obj/fv_View.o] Error 1

I presume because of this in fp_Fields.h :-

#ifndef NDEBUG
_FIELD(NUMBERS, AP_STRING_ID_FIELD_Numbers_EndnoteAnchor, endnote_anch)
_FIELD(NUMBERS, AP_STRING_ID_FIELD_Numbers_EndnoteReference, endnote_ref)
_FIELDTYPE(PIECETABLE, AP_STRING_ID_FIELD_Type_PieceTable)
_FIELD(PIECETABLE, AP_STRING_ID_FIELD_PieceTable_Test, test)
_FIELD(PIECETABLE, AP_STRING_ID_FIELD_PieceTable_MartinTest, martin_test)
#endif

Moving endnotes out of NDEBUG helps to compile at least. I'll file a
bug report if necessary.

Sincerely,

Adrian Phillips

-- 
Your mouse has moved.
Windows NT must be restarted for the change to take effect.
Reboot now?  [OK]

• Next message: Bryce Nesbitt: "Re: On the Road to version 1.0"
• Previous message: Savant shanti: "Other natural languages"
• In reply to: Tomas Frydrych: "commit: fv_View.cpp"
• Next in thread: Dom Lachowicz: "Re: commit: fv_View.cpp"
• Reply: Adrian Phillips: "Re: commit: fv_View.cpp"
• Reply: Dom Lachowicz: "Re: commit: fv_View.cpp"

This archive was generated by hypermail 2b25 : Fri Dec 21 2001 - 05:50:47 CST