Re: Abi crashers


Subject: Re: Abi crashers
From: Robert Wilhelm (robert@gaston.camelot.de)
Date: Sat Dec 29 2001 - 13:00:59 CST


On Thu, Dec 27, 2001 at 04:46:19PM -0500, Dom Lachowicz wrote:
> Hi Robert,
>
> I'm applying this patch for now, since it doesn't seem to hurt anything.
> I'll look into a better fix shortly unless someone beats me to it.
>

Hi Dom,

maybe you want to apply appended patch also:

Without it I get ( again with Zusammenfassung-der-Projektwoche.doc):

==============================
 Trace: (picf.c:172) Entry is 4, 167c6, count is 85560
 Trace: (picf.c:188) len is 2, predict end of 167ca
 Trace: (support.c:130) read_16ubit
 Trace: (support.c:130) read_16ubit
 Trace: (picf.c:172) Entry is 3, 167ce, count is 85568
 Trace: (support.c:130) read_16ubit
 Trace: (picf.c:180) suspect that we are finished, count 85570, len 85572
 Trace: (picf.c:238) Entry is 3 167d0, 85570
 Trace: (picf.c:88) len is 85572, header len guess is 85570
 Trace: (picf.c:108) len is now 16
 
**** (1) Assert ****
**** (1) position < m_iSize at ut_bytebuf.cpp:155 ****
**** (1) Continue ? (y/n) [y] :
======================================

And after the patch I get

=====================================
 Trace: (picf.c:172) Entry is 4, 167c6, count is 85560
 Trace: (picf.c:188) len is 2, predict end of 167ca
 Trace: (support.c:130) read_16ubit
 Trace: (support.c:130) read_16ubit
 Trace: (picf.c:172) Entry is 3, 167ce, count is 85568
 Trace: (support.c:130) read_16ubit
 Trace: (picf.c:180) suspect that we are finished, count 85570, len 85572
 Trace: (picf.c:238) Entry is 3 167d0, 85570
 Trace: (picf.c:88) len is 85572, header len guess is 85570
 Trace: (picf.c:91) all read ok methinks
 DEBUG: Couldn't import graphic!
Trace: (fib.c:657) RET is 6
 Trace: (decode_complex.c:235) current fc is 429
 Trace: (bte.c:143) valid
 Trace: (fkp.c:186) searching fkp 429 300
 Trace: (fkp.c:186) searching fkp 429 340
====================================================

[robert@gaston wv]$ cvs diff picf.c
Index: picf.c
===================================================================
RCS file: /cvsroot/wv/picf.c,v
retrieving revision 1.22
diff -u -r1.22 picf.c
--- picf.c 2001/12/27 21:44:55 1.22
+++ picf.c 2001/12/29 18:58:29
@@ -86,7 +86,7 @@
 
           i = wvEatOldGraphicHeader (fd, len);
           wvTrace (("len is %d, header len guess is %d\n", len, i));
- if (i + 1 >= len)
+ if (i + 2 >= len)
             {
                 wvTrace (("all read ok methinks\n"));
                 apicf->rgb = NULL;
 



This archive was generated by hypermail 2b25 : Sat Dec 29 2001 - 13:04:26 CST