Subject: Re: findPointsCoords signature and BiDi
From: Martin Sevior (msevior@mccubbin.ph.unimelb.edu.au)
Date: Thu Feb 08 2001 - 16:06:33 CST
On Thu, 8 Feb 2001, Tomas Frydrych wrote:
>
> The BiDi version of findPointCoords needs three more parameters:
> extra set of coordiances x2, y2 and a bDirection, which indicates
> the direction of the run immediately preceding the caret. The former
> two are needed because one physical location of the insertion point
> can have two simultaneous visual positions on the screen, the later
> is needed so that xorInsertionPoint can draw a direction flag at the
> top of the insertion point.
>
> Adopting the BiDi signature even for the non-bidi version reduces
> the number of #ifdef BIDI_ENABLED in the patch by 60, without
> any real impact on the performance.
I agree with this Tomas. I think your next patch should change the
definition of findpointcoords with and without bidi enabled.
Martin
This archive was generated by hypermail 2b25 : Thu Feb 08 2001 - 16:06:50 CST