Re: commit -- expat changes


Subject: Re: commit -- expat changes
From: Paul Rohr (paul@abisource.com)
Date: Wed Feb 21 2001 - 22:26:20 CST


At 04:39 PM 2/18/01 -0600, Sam TH wrote:
>These changes shouldn't actually affect anything, other than making
>your build quieter.
>
>A bunch of changes to expat:
>1) Added xmlwf back, as per Paul's reccomendation.
>2) Supressed some configure errors via autoconf magic
>3) Silenced libtool

Thanks, Sam.

One nit ... the additional per-source-file echo you put in isn't needed on
Win32. For example, see this snippet from abi/src/config/abi_rules.mk:

-- snip --

############################################################################
###
## Rule for building .cpp sources in the current directory into .o's in
$(OBJDIR)
############################################################################
###

$(OBJDIR)/%.$(OBJ_SUFFIX): %.cpp
        @$(MAKE_OBJDIR)
ifeq ($(OS_NAME), WIN32)
        @$(CCC) -Fo$(shell echo $@ | $(TRANSFORM_TO_DOS_PATH) ) -c $(CFLAGS) $<
else
        @echo $<:
        @$(CCC) -o $@ -c $(CFLAGS) $<
endif

-- snip --

I'm not sure what the relevant configure-style magic is to get this right,
but I'm sure you do. ;-)

Paul



This archive was generated by hypermail 2b25 : Wed Feb 21 2001 - 22:29:35 CST