Subject: Re: patch: Unix keboard handler UTF-8 support
From: Dom Lachowicz (cinamod@hotmail.com)
Date: Wed Jan 24 2001 - 12:36:49 CST
Hi Tomas,
There's only one thing that makes me wary about this patch:
#include <X11/X.h>
Please don't do this to just get a definition for the KeySym type,
especially if you're passing a GdkEvent->keyval to your keysym2ucs function.
GdkEvent->keyval is a guint guaranteed to be 32 bits and unsigned (a
UT_uint32 in AbiWord terminology). For future reference, *no* X11 headers
ever get included in AbiWord Unix code.
So, if you remove the #include <X11/X11.h> and change the definition of
keysym2ucs to one of the following new definitions, I'll commit your patch:
UT_sint32 keysym2ucs(guint keysym);
or
UT_sint32 keysyn2ucs(UT_uint32 keysym);
Thanks,
Dom
_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com
This archive was generated by hypermail 2b25 : Wed Jan 24 2001 - 12:36:52 CST