Subject: Re: Bug 1587 mislabelled dialogue - commit
From: Michael D. Pritchett (mpritchett@attglobal.net)
Date: Tue Jun 19 2001 - 17:06:13 CDT
On Tue, 19 Jun 2001, Mike Nordell wrote:
> Alan wrote:
> >
> > the font dialogue has been mislabelled as "Zoom" see the top left
> > corner.
>
> I can verify this.
>
I fess up. I did this. I was making changes to get the Font Dialog to
work and cleaning code. Obviously not well enough.
> I'm not sure why this localizations code if in this dialog at all, Windows
> localization should already have taken care of this. Unless, we're to be
> able to run AbiWord in e.g. Hungarian while the Windows locale is set to
> e.g. en-US.
Windows localization take care of a Standard Dialogs, but the additional
features in AbiWorld (like Overline) would be missed. I was attempting to
make the Dialog match on all platforms where possible instead of using the
default Windows localization. I could go either way in this case. At the
moment, I'll continue with AbiWord localization. If there is a strong
preference, I can be converted.
>
> Solutions: Either remove all localization code (unless e.g
> Hungarian-under-English is to be possible), or replace the comment in
> xap_String_Id.h from "Unix Font Selector dialog" to just "Font Selector
> dialog".
>
> As I don't know the intentions I didn't commit any changes.
>
Thanks for the consideration, but feel free to correct any and all mistake
I make. I am still learning.
Modified Files:
src/af/xap/win/xap_Win32Dlg_FontChooser.cpp
Cheers!
Michael D. Pritchett
This archive was generated by hypermail 2b25 : Tue Jun 19 2001 - 17:18:08 CDT