commit - Bugfix #946


Subject: commit - Bugfix #946
From: Michael D. Pritchett (mpritchett@attglobal.net)
Date: Sun Mar 11 2001 - 01:52:50 CST


Bugfix #946 Zoom Clipping

Modified Files

abi/src/af/xap/win/xap_Win32Dlg_Zoom.cpp
abi/src/af/xap/xp/xap_Dlg_Zoom.cpp
abi/src/af/xap/xp/xap_Frame.cpp

The bugzilla report was as follows:
-----------------------------------
1. Open the View->Zoom dialog.
2. Select "Percent".
3. Type a number less than 10 or greater than 500 for the percent.
4. Press Enter or click "OK".

The zoom dialog goes away, and nothing happens. There is no visual clue
that
the number that was entered was invalid.

That is reproducible on NT 4 but not Linux. The behavior on Linux makes
more
sense - the number will be clipped to the lowest or highest possible value
(actually, the lowest on Linux is 1%).
------------------------------------------

The fix for Windows was simple, but the constants used (found in
xap_Dlg_Zoom.h):
XAP_DLG_ZOOM_MINIMUM_ZOOM = 10
XAP_DLG_ZOOM_MAXIMUM_ZOOM = 500
obviously haven't been applied to Linux (minimum zoom of 1%). As a result,
I implimented zoom clipping in xp and added it to the dynamic zoom feature.

Minimum and Maximum zooms seem limiting at 10 and 500%. Was there a reason
for this setting or should it be changed to something like 1 and 1600%?



This archive was generated by hypermail 2b25 : Sun Mar 11 2001 - 02:09:04 CST