Subject: Re: Commit: Undoable Header/Footers plus Box while editting.
From: Dom Lachowicz (cinamod@hotmail.com)
Date: Tue Mar 20 2001 - 10:35:51 CST
Martin,
This is some really great work! Just two little nitpicks -
1) The line-width around the header/footer is too large. Please set it to
something smaller. IIRC, Word has a thin dashed line. A thin gray or black
line would be fine here
2) The text is not constrained to the drawn box, and I don't know if it's
intentional or not. To reproduce this, hit and hold down 'a' and see text
shoot left of the box. I'm guessing that we're just not breaking lines while
in a header/footer
This is some tremendous work!
Dom
>From: Martin Sevior <msevior@mccubbin.ph.unimelb.edu.au>
>To: abiword-dev@abisource.com
>Subject: Commit: Undoable Header/Footers plus Box while editting.
>Date: Wed, 21 Mar 2001 00:43:02 +1100 (EST)
>
>
>Inserting Header/Footers is now undoable. I had to invent a new
>PTX_SectionHdrFtr strux type. Now you can insert a header/footer by
>inserting a PTX_SectionHdrFtr strux. It is much easier to undo this than
>the other way (which still works) which is to change a DocSectionLayout to
>HdrFtrSectionLayout.
>
>Also a box appears around the header/footer
>upon editting. This box only appears around the header/footer containing
>the insertion point.
>
>There is a weird bug with this that I haven't fixed yet. If you try
>to enter text before the page number field on any other than the first
>page you get a segfault if the field is in the first position in a
>paragraph. Somehow there is a run that's not getting an AttProp's pointer
>correctly.
>
>Next: Double click in the header/footer region to insert a header/footer.
>
>More thoughts on header/footer UI to follow.
>
>Enjoy!
>
>Martin
>
>CVS: ----------------------------------------------------------------------
>CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
>CVS:
>CVS: Committing in .
>CVS:
>CVS: Modified Files:
>CVS: src/text/fmt/xp/fl_BlockLayout.cpp
>CVS: src/text/fmt/xp/fl_BlockLayout.h
>CVS: src/text/fmt/xp/fl_DocLayout.cpp
>CVS: src/text/fmt/xp/fl_DocListener.cpp
>CVS: src/text/fmt/xp/fl_Layout.cpp src/text/fmt/xp/fl_Layout.h
>CVS: src/text/fmt/xp/fl_SectionLayout.cpp
>CVS: src/text/fmt/xp/fl_SectionLayout.h
>CVS: src/text/fmt/xp/fp_Column.cpp src/text/fmt/xp/fp_Column.h
>CVS: src/text/fmt/xp/fv_View.cpp src/text/fmt/xp/fv_View.h
>CVS: src/text/ptbl/xp/pf_Frag_Strux_Section.cpp
>CVS: src/text/ptbl/xp/pf_Frag_Strux_Section.h
>CVS: src/text/ptbl/xp/pf_Frag_TestRoutines.cpp
>CVS: src/text/ptbl/xp/pt_PT_DeleteSpan.cpp
>CVS: src/text/ptbl/xp/pt_PT_DeleteStrux.cpp
>CVS: src/text/ptbl/xp/pt_PT_InsertStrux.cpp
>CVS: src/text/ptbl/xp/pt_PieceTable.cpp src/text/ptbl/xp/pt_Types.h
>CVS: src/wp/ap/xp/ap_EditMethods.cpp
>CVS: src/wp/impexp/xp/ie_exp_AbiWord_1.cpp
>CVS: src/wp/impexp/xp/ie_exp_Applix.cpp
>CVS: src/wp/impexp/xp/ie_exp_DocBook.cpp
>CVS: src/wp/impexp/xp/ie_exp_HTML.cpp
>CVS: src/wp/impexp/xp/ie_exp_LaTeX.cpp
>CVS: src/wp/impexp/xp/ie_exp_MsWord_97.cpp
>CVS: src/wp/impexp/xp/ie_exp_Psion.cpp
>CVS: src/wp/impexp/xp/ie_exp_RTF_listenerGetProps.cpp
>CVS: src/wp/impexp/xp/ie_exp_RTF_listenerWriteDoc.cpp
>CVS: src/wp/impexp/xp/ie_exp_Text.cpp
>CVS: src/wp/impexp/xp/ie_exp_UTF8.cpp
>CVS: src/wp/impexp/xp/ie_exp_WML.cpp
>CVS: ----------------------------------------------------------------------
>
>
>
_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com
This archive was generated by hypermail 2b25 : Tue Mar 20 2001 - 10:36:01 CST