Subject: Re: Patch: Win32 crash fix
From: Mike Nordell (tamlin@algonet.se)
Date: Fri May 18 2001 - 06:15:59 CDT
Andrew Dunbar wrote:
> case EV_EEMR_COMPLETE:
> - UT_ASSERT(pEM);
> - invokeKeyboardMethod(pView,pEM,&charData,1);
> + {
> + UT_ASSERT(pEM);
> + UT_UCSChar *ucs = new UT_UCSChar[1];
> + ucs[0] = charData;
> + invokeKeyboardMethod(pView,pEM,ucs,1);
> + delete [] ucs;
> + }
Why not simply:
UT_UCSChar ucs = charData;
invokeKeyboardMethod(pView,pEM,&ucs,1);
or if charData already is UT_UCSChar, why not use it directly? Why new'ing
an *array* of one single UT_UCSChar???
/Mike
This archive was generated by hypermail 2b25 : Sat May 26 2001 - 03:51:04 CDT