Re: Patch: Fix for Bug 1164, 2nd try


Subject: Re: Patch: Fix for Bug 1164, 2nd try
From: Hubert Figuiere (hfiguiere@teaser.fr)
Date: Tue May 22 2001 - 07:11:39 CDT


According to Dom Lachowicz <dominicl@seas.upenn.edu>:
> > > Thank you for research. That added chunk:
> > > else
> > > m_mbtowc.initialize();
> > > should be definitely removed.
> >
> > I'm not an iconv expert but I thought we needed something like
> > that to reset the internal state after trying and failing to
> > convert a character. Something *like* that - but not exactly that...
>
> This stops a few SEGVs. The iconv_t pointer was being corrupted and the
> internal state of the MbToWc most definitately needs to be reset.

Perhaps should we have a reinitialize () method that does the dirty work
without discarding everything ? Shouldn't we ?

Hub



This archive was generated by hypermail 2b25 : Sat May 26 2001 - 03:51:06 CDT