Subject: Re: Path to fix gently cockeyed DDE command parsing
From: Michael D. Pritchett (mpritchett@attglobal.net)
Date: Mon Sep 10 2001 - 14:15:53 CDT
On Mon, 10 Sep 2001, John Anderson wrote:
> Here's a patch to fix the gently cockeyed DDE command parsing code in
> src/af/xap/win/xap_Win32Slurp.cpp, in the 0.9.3 release version.
> According to LXR, the file hasn't been updated since 6-feb-2001.
>
> The problem occurs when you try to open a file with embedded [] in the
> name. MSIE 5.x uses [] in the temporary filenames it generates when
> you try to open a document from a web server.
>
> The patch also inserts a dde command string of [open("%1")] into the
> registry instead of [open(%1)]. This may have an effect with filenames
> containing embedded spaces, I'm not sure. All the other "open" command
> entries in the registry did have the quotes, though.
>
> AFAIK there isn't a bug number for this.
>
> have fun
>
> Freelance Data Munger http://www.semiosix.com
> Good Things require a precise lack of control
>
John - nice work. I will commit it shortly to the CVS code base and add
your name to the CREDITS.txt file.
For future references when creating diffs, I would appreciate unified diff
-u if possible.
Thanks.
Michael D. Pritchett
This archive was generated by hypermail 2b25 : Mon Sep 10 2001 - 14:29:22 CDT