Subject: Re: NextToken() in RTF importer - code review
From: Dom Lachowicz (dominicl@seas.upenn.edu)
Date: Thu Sep 20 2001 - 09:01:37 CDT
> I propose we stick to the standard, and closing bug 1207 by stating that
>
> the RTF file is non-compliant. This requires backing out the change I
> made
> to ie_imp_RTF.cpp, specifically function NextToken where:
> -----------------------
> while( pKeyword[0] == ' ')
> {
> if (!ReadCharFromFile(pKeyword))
> {
> tokenType = RTF_TOKEN_ERROR;
> }
> }
> -----------------------
> should be returned to:
> ----------------------
> if (!ReadCharFromFile(pKeyword))
> {
> tokenType = RTF_TOKEN_ERROR;
> }
> ---------------------
>
> What are your thoughts?
Hi Matti,
I believe that this should be reverted. I will make the appropriate changes to
the RTF importer as well as a nice fat comment from the spec. Please close bug 1211.
Dom
This archive was generated by hypermail 2b25 : Thu Sep 20 2001 - 09:01:46 CDT