Re: Warning platform maintainers

From: Hubert Figuiere (hfiguiere@teaser.fr)
Date: Tue Dec 03 2002 - 03:16:47 EST

  • Next message: j.m.maurer: "Re: Patch prize winner is..."

    On mardi, déc 3, 2002, at 00:45 Europe/Paris, Mike Nordell wrote:

    > Hubert Figuiere wrote:
    >
    >> In the last commit I fixed a double free of the popt context in the
    >> Cocoa code. While reviewing, I found out that it was caused by
    >> tamlin's
    >> leak fixes in the Win32 code.
    >
    > Ouch. Sorry Hub, obviously that wasn't my intention. But wouldn't it
    > make
    > more sense to let the arg class handle both the resource aquisituion
    > and
    > release instead of repeating the same code in every platform
    > implementation,
    > opening up for mistakes and misunderstandings like this?

    I completely agree. I warned platform maintainer, but I consider that
    free a resource in platform code while acquiring it is XP code is a bug.

    Can someone who understand the code have a look at that and fix it ?

    Hub

    This archive was generated by hypermail 2.1.4 : Tue Dec 03 2002 - 03:19:14 EST