Re: Bookmark bug patch


Subject: Re: Bookmark bug patch
From: Adrian Phillips (adrianp@powertech.no)
Date: Sun Jan 27 2002 - 08:16:03 CST


>>>>> "Christian" == Christian Biesinger <cbiesinger@web.de> writes:

Christian> On Sun, Jan 27, 2002 at 02:39:43PM +0100, Adrian
Christian> Phillips wrote:
>> XML_Char name[BOOKMARK_NAME_SIZE + 1]; +
>> name[BOOKMARK_NAME_SIZE] = 0; UT_XML_strncpy(name,
>> BOOKMARK_NAME_SIZE, (XML_Char*)szName);

Christian> Shouldn't the name[...] = 0 be done after the strncpy?

I don't see it matters, this is strncpy after all with a maximum copy
of BOOKMARK_NAME_SIZE, but yes I suppose it would be more logical to
swap it

Sincerely,

Adrian Phillips

-- 
Your mouse has moved.
Windows NT must be restarted for the change to take effect.
Reboot now?  [OK]



This archive was generated by hypermail 2b25 : Sun Jan 27 2002 - 08:16:13 CST