Re: [Wvware-devel] sprmPHugePapx2

From: Robert Wilhelm (robert@gaston.camelot.de)
Date: Fri Jun 14 2002 - 16:12:06 EDT

  • Next message: Kenneth J.Davis: "commit: NSIS reapply vc5 fixes"

    Thanks for the bug report.

    I have applied following patch to wv in abiword HEAD,
    will need to go into abiword STABLE and wv cvs repositories, too.

    Robert

    Index: support.c
    ===================================================================
    RCS file: /cvsroot/wv/support.c,v
    retrieving revision 1.30
    diff -u -r1.30 support.c
    --- support.c 14 May 2002 15:27:46 -0000 1.30
    +++ support.c 14 Jun 2002 20:13:32 -0000
    @@ -293,7 +293,7 @@
         else
           {
             in->stream.memory_stream->current = position;
    - return 0;
    + return in->stream.memory_stream->current;
           }
     }
     

    On Thu, Jun 13, 2002 at 11:02:05AM -0400, Corby Wilson wrote:
    > I just figured this one out.
    > (Sprm.c:1520)
    > if (0 != wvStream_goto(data,offset))
    > {
    > //Error
    > }
    > wvStream_goto returns the new value of position within the stream (just
    > like lseek or fseek). However, wvStream_goto returns the new pos only
    > if in->kind is LIBOLE_STREAM or FILE_STREAM. If it's a memory stream it
    > always returns 0, not sure if this is correct.
    >
    > If I invert the test at line 1520 it seems to work fine.
    >
    >
    > -----Original Message-----
    > From: wvware-devel-admin@lists.sourceforge.net
    > [mailto:wvware-devel-admin@lists.sourceforge.net] On Behalf Of Robert
    > Wilhelm
    > Sent: Wednesday, June 12, 2002 12:58 AM
    > To: Corby Wilson
    > Cc: wvware-devel@lists.sourceforge.net
    > Subject: Re: [Wvware-devel] sprmPHugePapx2
    >
    > On Tue, Jun 11, 2002 at 06:25:05PM -0400, Corby Wilson wrote:
    > > Has it been verified that sprmPHugePapx2 works. I get streaming
    > errors
    > > because the offset extracted from the sprm data is beyond the end of
    > the
    > > stream.
    > > Do we have any lit on this?
    > >
    > > Corby
    > >
    >
    > Could you please send a sample document with this behavior?
    >
    > Robert
    >
    >
    > _______________________________________________________________
    >
    > Sponsored by:
    > ThinkGeek at http://www.ThinkGeek.com/
    > _______________________________________________
    > Wvware-devel mailing list
    > Wvware-devel@lists.sourceforge.net
    > https://lists.sourceforge.net/lists/listinfo/wvware-devel



    This archive was generated by hypermail 2.1.4 : Fri Jun 14 2002 - 16:23:18 EDT