Re: Patch for Bug #2615 (unix)

From: Patrick Lam (plam@plam.lcs.mit.edu)
Date: Sun Mar 24 2002 - 20:17:18 EST

  • Next message: Randy Kramer: "Re: Patch for Bug #2615 (unix)"

    On Sun, Mar 24, 2002 at 05:04:38PM -0500, William Lachance wrote:
    > Here is a fix for bug #2615, which only occured on unix. Basically, I just
    > fixed it by copying and pasting some code from the windows version of the
    > same, which was correct. I give the same caveat as last time: someone more
    > familiar with this code than I may want to review it before committing.

    This patch works for me. Committed. Thanks Will!

    > I noticed that there is a lot of code duplication going on in the platform
    > specific frame stuff (there's like 2 lines worth of gtk! everything else is
    > substantially the same). We should probably figure out a way of refactoring
    > this post-1.0..

    Indeed.

    > Also, shouldn't this Document->close thing leaving a "blank document" rather
    > than "exiting" be turned off by default? I thought that was Dom's verdict
    > after the whole August kerfuffle. [ not that I'm trying to bring it up again
    > but fwiw I find this behaviour really silly ]

    I thought it should be turned off too...

    pat



    This archive was generated by hypermail 2.1.4 : Sun Mar 24 2002 - 20:18:05 EST