Re: What happened to justified paragraphs?

From: e98cuenc@free.fr
Date: Thu Aug 21 2003 - 04:14:56 EDT

  • Next message: Pierre Abbat: "Re: Virus and al."

    Selon Martin Sevior <msevior@seviorpc.ph.unimelb.edu.au>:

    > On Thu, 2003-08-21 at 19:02, Martin Sevior wrote:
    > > Hi Folks,
    > > Is it just my build or does full-justification not work any
    > > more?
    > > Who has has been messing around in fp-Line or fb_LineBreaker recently?
    > > Could the responsible person please fix things?
    > >
    > > We really don't need these regressions any more.
    > >
    > > (/me will appologize profusely if this turns out to be his fault.)
    > >
    >
    > Jordi,
    > It looks like your commit to fix 4593 caused this. Can you find a
    > different solution that gives us justified paragraphs back?
    >
    > See
    >
    > http://www.abisource.com/bonsai/cvsview2.cgi?
    root=/cvsroot&subdir=abi/src/text/fmt/xp&files=fp_Line.cpp&command=DIRECTORY

    Martin, try this code:

    /* avoid a division by zero if iSpaceCount is equal to 1 */
    UT_sint32 iJustifyAmountForRun = iSpaceCount == 1 ? iAmount : static_cast<int>
    (static_cast<double>(iAmount) / (iSpaceCount-1) * iMySpaces);

    I guess that Jordi though that it was

    iJustifyAmountForRun = iAmount / ((iSpaceCount-1) * iMySpaces)

    instead of

    iJustifyAmountForRun = (iAmount / (iSpaceCount-1)) * iMySpaces

    Now, back to lurker mode :)

    Cheers,

    This archive was generated by hypermail 2.1.4 : Thu Aug 21 2003 - 04:27:50 EDT