Re: Regarding fp_TextRun::_draw

From: Tomas Frydrych (tomas_at_frydrych.uklinux.net)
Date: Tue Dec 02 2003 - 14:10:58 EST

  • Next message: Tomas Frydrych: "Re: Regarding fp_TextRun::_draw"

    Hi Jordi,

    yes, we need to call both _stripLigaturePlaceHolders() and
    _calculateCharAdvances() (in that order) before we start drawing; we
    do so in the head (line 1584, just before if(pG-
    >queryProperties(GR_Graphics::DGP_SCREEN) && pG-
    >queryProperties(GR_Graphics::DGP_OPAQUEOVERLAY)))

    Tomas

    Date sent: Tue, 02 Dec 2003 18:42:27 +0100
    From: Jordi Mas <jmas_at_softcatala.org>
    To: AbiWord <abiword-dev_at_abisource.com>
    Subject: Regarding fp_TextRun::_draw

    > Hello,
    >
    > Under Win32 if you open Abiword and type a few letters, the line 1795 at
    > fp_TextRun::_draw containing this code:
    >
    > getGR()->drawChars(s_pCharBuff, iMyOffset,
    > iSegmentOffset[iSegment+1]-iSegmentOffset[iSegment],
    > iX, yTopOfRun,s_pCharAdvance + iMyOffset);
    >
    > has a problem. s_pCharAdvance has been allocated but not initialised.
    > Basically, we are passing to drawChars an uninitialised piece of memory.
    > I guess that _calculateCharAdvances should be called first.
    >
    > Any idea? I'm just pointing a problem. I'm not familiar with this piece of code.
    >
    > Thanks
    > --
    >
    > Jordi Mas i Hernāndez (homepage http://www.softcatala.org/~jmas)
    > http://www.softcatala.org
    >



    This archive was generated by hypermail 2.1.4 : Tue Dec 02 2003 - 14:17:13 EST