Commit (HEAD): fix bug 4908 and 4967 (BREAKING Win32 and QNX)

From: Hubert Figuiere (hfiguiere_at_teaser.fr)
Date: Tue Dec 09 2003 - 18:52:32 EST

Next message: Alan Horkan: "Tabiword (Tablet abiword)"

Previous message: Marc Maurer: "Commit (HEAD): Revert: Re: commit: fixes encoding problems in win32"
Next in thread: Hubert Figuiere: "Commit (STABLE2): fix bug 4908 and 4967 (Still BREAKING QNX)"
Reply: Hubert Figuiere: "Commit (STABLE2): fix bug 4908 and 4967 (Still BREAKING QNX)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Fix bug 4908 and bug 4967: toolbar were hardocded into GUI.... (and
missing Table toolbar).

I made a few changes into XP framework, and did the appropriate
changes in UNIX and MacOS X front-end. It will break Win32 and QNX. It
will add a few strings and remove a few others.
I did not change Win32 because there are a few things I don't really
feel to do: WiN32 seems to have a control for each toolbar instead of
a list like in MacOS X and Unix. Same for QNX.... <sigh>

What you have to do in the Dialog_Option:

do this to fill in the widget that list the toolbars.

const UT_Vector & vec =
      XAP_App::getApp()->getToolbarFactory()->getToolbarNames();
UT_uint32 i;
for (i = 0; i < vec.getItemCount(); i++) {
       str = reinterpret_cast<const
                               UT_UTF8String*>(vec.getNthItem(i))->utf8_str();
       // add to the widget
}

Remove: (3 of each for 4 toolbars !!)
_setViewShow*Bar()
_gatherViewShow*Bar()

Implement pure virtual functions:
_gatherViewShowToolbar()
_setViewShowToolbar()

I might backport this to STABLE, including the Win32 and QNX fix. This
will not happen before 2.0.2

CVS: Modified Files:
CVS: src/af/xap/xp/xap_Toolbar_Layouts.h
CVS: src/wp/ap/cocoa/ap_CocoaDialog_Options.h
CVS: src/wp/ap/cocoa/ap_CocoaDialog_Options.mm
CVS: src/wp/ap/unix/ap_UnixDialog_Options.cpp
CVS: src/wp/ap/unix/ap_UnixDialog_Options.h
CVS: src/wp/ap/xp/ap_Dialog_Options.cpp
CVS: src/wp/ap/xp/ap_Dialog_Options.h
CVS: src/wp/ap/xp/ap_EditMethods.cpp
CVS: src/wp/ap/xp/ap_Menu_ActionSet.cpp
CVS: src/wp/ap/xp/ap_Menu_Functions.cpp
CVS: src/wp/ap/xp/ap_Menu_Functions.h
CVS: src/wp/ap/xp/ap_Menu_Id_List.h
CVS: src/wp/ap/xp/ap_Menu_Layouts_MainMenu.h
CVS: src/wp/ap/xp/ap_String_Id.h
CVS: src/wp/ap/xp/ap_TB_Layouts_ExtraOps.h
CVS: src/wp/ap/xp/ap_TB_Layouts_FileEditOps.h
CVS: src/wp/ap/xp/ap_TB_Layouts_FormatOps.h
CVS: src/wp/ap/xp/ap_TB_Layouts_TableOps.h
CVS: src/wp/ap/xp/ap_Toolbar_Layouts.cpp

Cheers

Hub

-- 
AbiWord maintainer - Lille, France
http://www.figuiere.net/hub/ 
GPG fingerprint: 6C44 DB3E 0BF3 EAF5 B433  239A 5FEE 05E6 A56E 15A3

Next message: Alan Horkan: "Tabiword (Tablet abiword)"
Previous message: Marc Maurer: "Commit (HEAD): Revert: Re: commit: fixes encoding problems in win32"
Next in thread: Hubert Figuiere: "Commit (STABLE2): fix bug 4908 and 4967 (Still BREAKING QNX)"
Reply: Hubert Figuiere: "Commit (STABLE2): fix bug 4908 and 4967 (Still BREAKING QNX)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

This archive was generated by hypermail 2.1.4 : Tue Dec 09 2003 - 18:51:35 EST