Re: commit: win32 crash on startup fix

From: Andrew Dunbar (hippietrail@yahoo.com)
Date: Wed Feb 05 2003 - 21:46:38 EST

  • Next message: Martin Sevior: "commit: non-debug builds work again."

     --- "Kenneth J. Davis" <jeremyd@computer.org> wrote:
    > This should prevent Omer's crash on startup issue
    > [see thread Win32 build 1.1.2.1104 or Crashes For Me
    > (TM)]
    >
    > Basically the check for a string-set was calling
    > strlen on a NULL
    > pointer returned for the fallback locale when there
    > was none.
    >
    > Sidenote: iw-IL is what we get in 2000, he-IL is
    > what we get in
    > XP, I assume he-IL is the proper one (given that's
    > the one we have
    > a string-set for). Can anyone familiar with the
    > lang/locale stuff
    > point me to which file(s) need adjusting to coerce
    > iw-IL into he-IL?
    > or suggest an alternate approach to handle them
    > identically?

    Look in xap_Win32EncodingManager and you'll see we
    already handle several special cases with locale
    names. he-IL is now correct. ISO made the change a
    little while back.
    If nobody's fixed it already I'll try to do it today.

    Andrew Dunbar.

    > Thanks,
    > Jeremy
    >
    >
    > CVS:
    >
    ----------------------------------------------------------------------
    > CVS: Enter Log. Lines beginning with `CVS:' are
    > removed automatically
    > CVS:
    > CVS: Committing in .
    > CVS:
    > CVS: Modified Files:
    > CVS: ap_Win32App.cpp ap_Win32FrameImpl.cpp
    > ap_Win32Prefs.cpp
    > CVS:
    >
    ----------------------------------------------------------------------
    > prevent crash on startup when no stringset and no
    > fallback
    >
    >

    =====
    http://linguaphile.sourceforge.net/cgi-bin/translator.pl http://www.abisource.com

    __________________________________________________
    Do You Yahoo!?
    Everything you'll ever need on one web page
    from News and Sport to Email and Music Charts
    http://uk.my.yahoo.com



    This archive was generated by hypermail 2.1.4 : Wed Feb 05 2003 - 21:50:00 EST