[Fwd: Re: ap_Frame classes (was Re: commit (HEAD): bidi fixes and toolbar]

From: William Lachance (william.lachance@sympatico.ca)
Date: Mon Jan 27 2003 - 16:41:42 EST

  • Next message: Pierre Abbat: "commit: Yiddish"

    attached mail follows:


    On Mon, 2003-01-27 at 05:10, Tomas Frydrych wrote:
    > Hi William,
    >
    > > The purpose was to consolidate code that is identical across
    > > platforms. So instead of cutting and pasting the same code in an
    > > AP_XXXFrame class, it can simply be declared once in an AP_Frame
    > > class.
    > OK, I get it now; but why then do we need ap_win32Frame class,
    > etc.? Should not all the the xp code be in ap_Frame class and
    > anything else in ap_XXXFrame classes?

    Yes, keeping in mind the distinction between xap and ap (described in my
    earlier mail). I consider any duplicated code between platforms (and I
    know there is some) in xap_xxxFrameImpl and ap_xxxFrame to be a bug.

    Cheers,

    -- 
    William Lachance <william.lachance@sympatico.ca>
    


    This archive was generated by hypermail 2.1.4 : Mon Jan 27 2003 - 16:41:09 EST