Commit: C++ casts and const-correctness

From: Andrew Dunbar (hippietrail@yahoo.com)
Date: Sun Mar 02 2003 - 22:20:30 EST

  • Next message: Marc Maurer: "gcc 2.96 and his strict casting"

    I've just committed the remainder of my C -> C++
    cast conversions and const-correctness work.
    Most files are affected, some problems are expected
    in a commit this size.

    Only cross-platform and Unix code is changed so far.
    Windows code will be updated when I can.

    I've tested xft, non-xft, debug, non-debug, pspell,
    and ispell. Some other build paths are surely not
    tested. Please test your favourite.

    If you find a problem, please try to change it to the
    appropriate C++ cast first. Use C casts only when
    absolutely necessary.
    If you must use a C cast, please include a comment and
    mention which compiler it is for or why it must be so.
    I'll grep for casts from time to time in the future
    so you won't want to fix the same one each time.

    I'm not entirely happy with the const-correctness
    of UT_Vector. Using this class seems to require
    double casts or C casts very often. Please fix this
    if you know how it should be.

    Apologies in advance for the donuts I'm sure to owe
    after this.

    *Please* try to use C++ casts in all future code!
    They really are better!

    Andrew Dunbar.

    CVS:
    ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are
    removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: src/af/ev/unix/ev_UnixToolbar.cpp
    CVS: src/af/ev/xp/ev_Menu_Layouts.cpp
    CVS: src/af/gr/unix/gr_UnixGraphics.cpp
    CVS: src/af/util/unix/ut_unixIdle.cpp
    CVS: src/af/util/win/ut_win_iconv.cpp
    src/af/util/xp/ut_Script.cpp
    CVS: src/af/xap/unix/xap_UnixClipboard.cpp
    CVS: src/af/xap/unix/xap_UnixClipboard.h
    CVS: src/af/xap/unix/xap_UnixDlg_FontChooser.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_HTMLOptions.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_Image.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_Insert_Symbol.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_MessageBox.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_Password.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_PluginManager.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_Print.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_WindowMore.cpp
    CVS: src/af/xap/unix/xap_UnixDlg_Zoom.cpp
    CVS: src/af/xap/unix/xap_UnixEncodingManager.cpp
    CVS: src/af/xap/unix/xap_UnixFont.cpp
    CVS: src/af/xap/unix/xap_UnixFontManager.cpp
    CVS: src/af/xap/unix/xap_UnixFontPreview.cpp
    CVS: src/af/xap/unix/xap_UnixFontXLFD.cpp
    CVS: src/af/xap/unix/xap_UnixFrameImpl.cpp
    CVS: src/af/xap/unix/xap_UnixModule.cpp
    CVS: src/af/xap/unix/xap_UnixNullGraphics.cpp
    CVS: src/af/xap/unix/xap_UnixPSGenerate.cpp
    CVS: src/af/xap/unix/xap_UnixPSGenerate.h
    CVS: src/af/xap/unix/xap_UnixPSGraphics.cpp
    CVS: src/af/xap/unix/xap_UnixPSImage.cpp
    CVS: src/af/xap/unix/xap_UnixTableWidget.cpp
    CVS: src/af/xap/unix/xap_UnixToolbar_Icons.cpp
    CVS:
    src/af/xap/unix/gnome/xap_UnixGnomeDlg_Print.cpp
    CVS:
    src/af/xap/unix/gnome/xap_UnixGnomePrintGraphics.cpp
    CVS: src/af/xap/xp/xad_Document.cpp
    src/af/xap/xp/xap_App.cpp
    CVS: src/af/xap/xp/xap_App.h
    src/af/xap/xp/xap_Dialog.cpp
    CVS: src/af/xap/xp/xap_Dialog.h
    src/af/xap/xp/xap_Dictionary.cpp
    CVS: src/af/xap/xp/xap_Draw_Symbol.cpp
    CVS: src/af/xap/xp/xap_FakeClipboard.cpp
    CVS: src/af/xap/xp/xap_FakeClipboard.h
    CVS: src/af/xap/xp/xap_FontPreview.cpp
    src/af/xap/xp/xap_Frame.cpp
    CVS: src/af/xap/xp/xap_Module.h
    src/af/xap/xp/xap_ModuleManager.cpp
    CVS: src/af/xap/xp/xav_Listener.h
    src/af/xap/xp/xav_View.h
    CVS: src/other/spell/xp/ispell_checker.cpp
    CVS: src/text/fmt/xp/fg_Graphic.cpp
    src/text/fmt/xp/fl_AutoNum.cpp
    CVS: src/text/fmt/xp/fl_AutoNum.h
    CVS: src/text/fmt/xp/fl_BlockLayout.cpp
    CVS: src/text/fmt/xp/fl_BlockLayout.h
    CVS: src/text/fmt/xp/fl_ContainerLayout.cpp
    CVS: src/text/fmt/xp/fl_DocLayout.cpp
    CVS: src/text/fmt/xp/fl_DocLayout.h
    CVS: src/text/fmt/xp/fl_FootnoteLayout.cpp
    CVS: src/text/fmt/xp/fl_Layout.h
    CVS: src/text/fmt/xp/fl_SectionLayout.cpp
    CVS: src/text/fmt/xp/fl_SectionLayout.h
    CVS: src/text/fmt/xp/fl_TableLayout.cpp
    CVS: src/text/fmt/xp/fp_Column.cpp
    CVS: src/text/fmt/xp/fp_ContainerObject.cpp
    CVS: src/text/fmt/xp/fp_ContainerObject.h
    CVS: src/text/fmt/xp/fp_FootnoteContainer.cpp
    CVS: src/text/fmt/xp/fp_Line.cpp
    src/text/fmt/xp/fp_Page.cpp
    CVS: src/text/fmt/xp/fp_Run.cpp
    src/text/fmt/xp/fp_Run.h
    CVS: src/text/fmt/xp/fv_View.cpp
    src/text/fmt/xp/fv_View.h
    CVS: src/text/fmt/xp/fv_View_cmd.cpp
    CVS: src/text/fmt/xp/fv_View_protected.cpp
    CVS: src/text/ptbl/xp/pd_Document.cpp
    CVS: src/text/ptbl/xp/pd_Document.h
    CVS: src/text/ptbl/xp/pf_Frag_Object.cpp
    CVS: src/text/ptbl/xp/pf_Frag_TestRoutines.cpp
    CVS: src/text/ptbl/xp/pt_PT_ChangeObject.cpp
    CVS: src/text/ptbl/xp/pt_PT_DeleteSpan.cpp
    CVS: src/text/ptbl/xp/pt_PT_DeleteStrux.cpp
    CVS: src/text/ptbl/xp/pt_PT_Undo.cpp
    CVS: src/text/ptbl/xp/pt_PieceTable.cpp
    CVS: src/wp/ap/unix/ap_UnixApp.cpp
    CVS: src/wp/ap/unix/ap_UnixClipboard.cpp
    CVS: src/wp/ap/unix/ap_UnixClipboard.h
    CVS: src/wp/ap/unix/ap_UnixDialog_Break.cpp
    CVS: src/wp/ap/unix/ap_UnixDialog_InsertTable.cpp
    CVS: src/wp/ap/unix/ap_UnixDialog_PageSetup.cpp
    CVS: src/wp/ap/unix/ap_UnixFrame.cpp
    CVS: src/wp/ap/unix/ap_UnixLeftRuler.cpp
    CVS: src/wp/ap/unix/ap_UnixToolbar_FontCombo.cpp
    CVS: src/wp/ap/unix/ap_UnixToolbar_SizeCombo.cpp
    CVS: src/wp/ap/unix/ap_UnixToolbar_StyleCombo.cpp
    CVS: src/wp/ap/unix/ap_UnixToolbar_ZoomCombo.cpp
    CVS: src/wp/ap/unix/ap_UnixTopRuler.cpp
    src/wp/ap/xp/ap_Args.cpp
    CVS: src/wp/ap/xp/ap_Dialog_Background.cpp
    CVS: src/wp/ap/xp/ap_Dialog_Columns.cpp
    CVS: src/wp/ap/xp/ap_Dialog_FormatTable.cpp
    CVS: src/wp/ap/xp/ap_Dialog_Lists.cpp
    CVS: src/wp/ap/xp/ap_Dialog_Lists.h
    CVS: src/wp/ap/xp/ap_Dialog_MergeCells.cpp
    CVS: src/wp/ap/xp/ap_Dialog_Spell.cpp
    CVS: src/wp/ap/xp/ap_EditMethods.cpp
    src/wp/ap/xp/ap_Frame.cpp
    CVS: src/wp/ap/xp/ap_LeftRuler.cpp
    src/wp/ap/xp/ap_LeftRuler.h
    CVS: src/wp/ap/xp/ap_Menu_Functions.cpp
    CVS: src/wp/ap/xp/ap_StatusBar.cpp
    src/wp/ap/xp/ap_TopRuler.cpp
    CVS: src/wp/impexp/xp/ie_Table.cpp
    src/wp/impexp/xp/ie_exp.cpp
    CVS: src/wp/impexp/xp/ie_exp_AbiWord_1.cpp
    CVS: src/wp/impexp/xp/ie_exp_GZipAbiWord.cpp
    CVS: src/wp/impexp/xp/ie_exp_HTML.cpp
    CVS: src/wp/impexp/xp/ie_exp_MsWord_97.cpp
    CVS:
    src/wp/impexp/xp/ie_exp_RTF_listenerGetProps.cpp
    CVS:
    src/wp/impexp/xp/ie_exp_RTF_listenerWriteDoc.cpp
    CVS: src/wp/impexp/xp/ie_imp.cpp
    src/wp/impexp/xp/ie_impGraphic.cpp
    CVS: src/wp/impexp/xp/ie_impGraphic_PNG.cpp
    CVS: src/wp/impexp/xp/ie_impGraphic_SVG.cpp
    CVS: src/wp/impexp/xp/ie_imp_AbiWord_1.cpp
    CVS: src/wp/impexp/xp/ie_imp_GZipAbiWord.cpp
    CVS: src/wp/impexp/xp/ie_imp_GraphicAsDocument.cpp
    CVS: src/wp/impexp/xp/ie_imp_MsWord_97.cpp
    CVS: src/wp/impexp/xp/ie_imp_RTF.cpp
    src/wp/impexp/xp/ie_imp_RTF.h
    CVS: src/wp/impexp/xp/ie_imp_Text.cpp
    CVS: src/wp/impexp/xp/ie_imp_XHTML.cpp
    CVS: src/wp/impexp/xp/ie_imp_XML.cpp
    src/wp/impexp/xp/ie_types.h
    CVS:
    ----------------------------------------------------------------------

    C -> C++ cast conversions
    Const-correctness
    The usual few typo fixes and comment changes.

    Andrew.

    =====
    http://linguaphile.sourceforge.net/cgi-bin/translator.pl http://www.abisource.com

    __________________________________________________
    Do You Yahoo!?
    Everything you'll ever need on one web page
    from News and Sport to Email and Music Charts
    http://uk.my.yahoo.com



    This archive was generated by hypermail 2.1.4 : Sun Mar 02 2003 - 22:26:26 EST