From: Marc Maurer (j.m.maurer@student.utwente.nl)
Date: Thu Mar 06 2003 - 18:39:50 EST
I designed it this way (ie. no MI), after some discussion on #abiword.
Dom suggested this idea, and we "concluded" that using MI should be
avoided if possible. Also, I can't see how this move would result in
"less bugs".
Not that I care that much to change it, just a note to the /dev/null on
your machine :)
> Also made the indentation style conform to the AbiSource guidelines.
>From the AbiWord Coding Guidelines:
"14. Indents are 4 spaces or 1 tab. Tabs are 4 spaces."
Which is not what you did (eg. you changed TABs to 3 spaces, and there
are several TABS all over the place as well, see for example
IE_Imp_WordPerfect::insertText). Quite frankly, it sucks. My use of TABS
was conform the ABI Coding Guidelines.
Not take I really care or anything, but when you "fix" anything, do it
properly.
Bye!
Marc
Op vr 07-03-2003, om 00:16 schreef William Lachance:
> Remove an unnecessary marshaller class through the miracle of multiple
> inheritance. Less code, less bugs. The classes I'm aggregrating are
> completely orthogonal: please forward your complaints about the use of
> MI to /dev/null/.
>
> Also made the indentation style conform to the AbiSource guidelines.
>
> Log:
> Checking in xp/ie_exp_WordPerfect.cpp;
> /cvsroot/abiword-plugins/wp/impexp/wordperfect/xp/ie_exp_WordPerfect.cpp,v <--
> ie_exp_WordPerfect.cpp
> new revision: 1.15; previous revision: 1.14
> done
> Checking in xp/ie_imp_WordPerfect.cpp;
> /cvsroot/abiword-plugins/wp/impexp/wordperfect/xp/ie_imp_WordPerfect.cpp,v <--
> ie_imp_WordPerfect.cpp
> new revision: 1.19; previous revision: 1.18
> done
> Checking in xp/ie_imp_WordPerfect.h;
> /cvsroot/abiword-plugins/wp/impexp/wordperfect/xp/ie_imp_WordPerfect.h,v <-- ie_imp_WordPerfect.h
> new revision: 1.14; previous revision: 1.13
> done
-- Marc Maurer <j.m.maurer@student.utwente.nl>
This archive was generated by hypermail 2.1.4 : Thu Mar 06 2003 - 18:40:55 EST