Re: cache bug 5137.

From: Hubert Figuiere (hfiguiere@teaser.fr)
Date: Fri May 23 2003 - 02:46:45 EDT

Next message: Hubert Figuiere: "Commit: fix bug 5137"

Previous message: Martin Sevior: "cache bug 5137."
In reply to: Martin Sevior: "cache bug 5137."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

On vendredi, mai 23, 2003, at 08:11 Europe/Paris, Martin Sevior wrote:

> Hi Hub,
> Please fix bug 5137. Other than that the new cache code seems as fast
> as ever.

The main issue that I missed is that XAP_UnixFontHandle::m_font is
mutable. Since I compute a hashKey based on the font name
(m_font->getName()), when m_font is changed (no the pointer, but the
object), the hashKey becomes wrong. But I don't get notified of that
change (and there is probably no way I can be)

I'll dig into that, but I might switch to plan B [1]

Hub
[1] revert the patch

-- 
Unemployed AbiWord maintainer - http://www.figuiere.net/hub/
Cell: +33 6 18 01 42 11 - AIM, Yahoo!: hfiguiere ICQ: 307453487
Any HTML e-mail sent to me will be discarded.

Next message: Hubert Figuiere: "Commit: fix bug 5137"
Previous message: Martin Sevior: "cache bug 5137."
In reply to: Martin Sevior: "cache bug 5137."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

This archive was generated by hypermail 2.1.4 : Fri May 23 2003 - 03:01:40 EDT