Re: Ping: Patch bug5291e

From: Dom Lachowicz (domlachowicz@yahoo.com)
Date: Sun Oct 05 2003 - 17:56:17 EDT

  • Next message: Martin Sevior: "commit:(HEAD) Fix this. Re: Cannot Clear Tabs in Abiword 2.0"

    I Strongly dislike parts of this patch.

    It shouldn't be assumed that the 'const char *'
    constructor means that you want the string to be
    external. If anything, the default should be "always
    intern the string, unless explicitly specified
    otherwise."

    Yeah, this patch might speed some things up. But it
    muddies the UT_String class, so it's not going in.

    Give this another try, maybe using FJF's new String
    map instead of UT_StringPtrMap.

    Dom

    --- Robert Wilhelm <robert.wilhelm@gmx.net> wrote:
    > Hi Dom,
    >
    > the patch from Johnny Lee to ut_string* gives us
    > quite a boost
    > in performance.
    > In my benchmark (user time for starting Abi,loading
    > RTF-Spec and
    > quitting), the time decreases from 30s to 25s (CVS
    > Head).
    >
    > Can you please take a look and decide whether it is
    > ok to expand
    > our string classes by this hack.
    >
    >
    http://www.abisource.com/mailinglists/abiword-dev/2003/Oct/att-0035/01-bug5291e.txt
    >
    > Robert
    >

    __________________________________
    Do you Yahoo!?
    The New Yahoo! Shopping - with improved product search
    http://shopping.yahoo.com

    This archive was generated by hypermail 2.1.4 : Sun Oct 05 2003 - 18:12:06 EDT