Re: Commit: massive font cleanup

From: Dom Lachowicz (domlachowicz@yahoo.com)
Date: Sat Oct 11 2003 - 19:53:15 EDT

  • Next message: Dom Lachowicz: "Commit: fix memory leaks"

    Apologies for replying to myself -

    I just made the d'tor protected so that noone can call
    it, besides GR_Graphics.

    In doing so, I found a place or two that tried to
    delete fonts (that I missed in my first pass).

    This should also be backported.

    Best regards,
    Dom

    --- Dom Lachowicz <domlachowicz@yahoo.com> wrote:
    > This now finally establishes a sane-ish ownership
    > model for fonts. In short, you never own it. Don't
    > delete it.
    >
    > This enables the mailmerge work to all be printed
    > out
    > as one page (now with 100% less crashing for docs
    > longer than 1 page!). This also moves the font cache
    > from FL_DocLayout (huh?) to GR_Graphics.
    >
    > The graphics class owns the font. Only the graphics
    > class can destroy the font.
    >
    > Also, fixes a memory leak or two, an invalid
    > startPrint call introduced by Martin, a bunch of
    > d'tors not being marked as virtual, and a bogus
    > memory
    > access caused by me.
    >
    > This *MUST* be backported.
    >
    > Make realrealrealrealclean about 10x just to make
    > sure
    > that you don't screw anything up with stale files.
    > This goes for autoconf too, as I got bitten myself.
    >
    > Apologies if any typos break the !Unix builds.
    > Should
    > be easy to fix, though.
    >
    > Cheers,
    > Dom
    >
    > CVS:
    >
    ----------------------------------------------------------------------
    > CVS: Enter Log. Lines beginning with `CVS:' are
    > removed automatically
    > CVS:
    > CVS: Committing in .
    > CVS:
    > CVS: Modified Files:
    > CVS: src/af/gr/cocoa/gr_CocoaGraphics.h
    > CVS: src/af/gr/cocoa/gr_CocoaGraphics.mm
    > CVS: src/af/gr/qnx/gr_QNXGraphics.cpp
    > CVS: src/af/gr/qnx/gr_QNXGraphics.h
    > CVS: src/af/gr/unix/gr_UnixGraphics.cpp
    > CVS: src/af/gr/unix/gr_UnixGraphics.h
    > CVS: src/af/gr/win/gr_Win32Graphics.cpp
    > CVS: src/af/gr/win/gr_Win32Graphics.h
    > src/af/gr/xp/gr_Graphics.cpp
    > CVS: src/af/gr/xp/gr_Graphics.h
    > CVS:
    > src/af/xap/unix/xap_UnixDlg_FileOpenSaveAs.cpp
    > CVS: src/af/xap/unix/xap_UnixFont.h
    > CVS: src/af/xap/unix/xap_UnixNullGraphics.cpp
    > CVS: src/af/xap/unix/xap_UnixNullGraphics.h
    > CVS: src/af/xap/unix/xap_UnixPSFont.cpp
    > CVS: src/af/xap/unix/xap_UnixPSFont.h
    > CVS: src/af/xap/unix/xap_UnixPSGraphics.cpp
    > CVS: src/af/xap/unix/xap_UnixPSGraphics.h
    > CVS:
    > src/af/xap/unix/gnome/xap_UnixGnomePrintGraphics.cpp
    > CVS:
    > src/af/xap/unix/gnome/xap_UnixGnomePrintGraphics.h
    > CVS: src/af/xap/xp/xap_Dlg_FontChooser.cpp
    > CVS: src/af/xap/xp/xap_Preview_Zoom.cpp
    > CVS: src/text/fmt/xp/fl_DocLayout.cpp
    > CVS: src/text/fmt/xp/fl_DocLayout.h
    > src/text/fmt/xp/fv_View.cpp
    > CVS: src/text/fmt/xp/fv_View_cmd.cpp
    > src/text/ptbl/xp/fd_Field.cpp
    > CVS: src/wp/ap/unix/ap_UnixApp.cpp
    > src/wp/ap/xp/ap_Convert.cpp
    > CVS: src/wp/ap/xp/ap_Dialog_Lists.cpp
    > CVS: src/wp/ap/xp/ap_Preview_Paragraph.cpp
    > CVS: src/wp/impexp/xp/ie_mailmerge.cpp
    > CVS:
    >
    ----------------------------------------------------------------------
    >
    >
    > __________________________________
    > Do you Yahoo!?
    > The New Yahoo! Shopping - with improved product
    > search
    > http://shopping.yahoo.com

    __________________________________
    Do you Yahoo!?
    The New Yahoo! Shopping - with improved product search
    http://shopping.yahoo.com

    This archive was generated by hypermail 2.1.4 : Sat Oct 11 2003 - 20:09:44 EDT