Re: pt_PieceTable::_getStruxFromFragSkip

From: msevior@physics.unimelb.edu.au
Date: Sat Sep 06 2003 - 18:29:12 EDT

  • Next message: Marc Maurer: "Re: pt_PieceTable::_getStruxFromFragSkip"

    > When loading guadec-4.zabw and just doing C-A C-X C-V one or
    > several times, my AbiWord CVS HEAD crashes in
    > pt_PieceTable::_getStruxFromFragSkip doing a isFootnote(pf)
    > with pf == 0x0.
    >

    Hi Robert,
               This would probobally just mask the real problem. (I guess we
    should apply the patch anyway. It would add robustness.) Can
    you explain how to reproduce this bug? I'll fix it properly
    once I can reproduce.

    Thanks!

    Martin

    > Probably we need something like a attached (untested) patch.
    >
    > diff -u -r1.102 pt_PieceTable.cpp
    > --- pt_PieceTable.cpp 19 Aug 2003 04:18:12 -0000 1.102
    > +++ pt_PieceTable.cpp 6 Sep 2003 15:25:13 -0000
    > @@ -889,6 +889,10 @@
    > || isFootnote(pf) ||
    > isEndFootnote(pf)))
    > {
    > pf=pf->getPrev();
    > +
    > + if (!pf)
    > + return false;
    > +
    > if(isFootnote(pf))
    > {
    > countFoots--;

    This archive was generated by hypermail 2.1.4 : Sat Sep 06 2003 - 18:45:55 EDT