Comitted: Re: Patch: Fix MSVC build error in ie_imp_RTF.cpp

From: Martin Sevior (msevior_at_seviorpc.ph.unimelb.edu.au)
Date: Fri Apr 16 2004 - 02:58:12 EDT

  • Next message: Martin Sevior: "commit: Fix Top ruler with Table in Header."

                                                                                    
    CVS:
    ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: wp/impexp/xp/ie_imp_RTF.cpp
    CVS:
    ----------------------------------------------------------------------
    Mikey's MSVC build fix.

    On Wed, 2004-04-14 at 14:48, Mikey Cooper wrote:
    > In ie_imp_RTF.cpp, line 9759 reads "FREEP(const_cast<XML_Char*>(sz));" which
    > generates "error C2106: '=' : left operand must be l-value" in MSVC (doesn't
    > happen under MinGW). MSVC does not seem to like casting l-values, even if
    > it's cast as a pointer.
    >
    > I made a patch that just converts "FREEP" to "free", based on this email:
    > http://www.abisource.com/mailinglists/abiword-dev/00/September/0085.html
    >
    > It lets MSVC build properly, but not sure if I'm introducing some kind of
    > memory leak. Patch attached.

    This archive was generated by hypermail 2.1.4 : Fri Apr 16 2004 - 02:10:45 EDT