From: Marc Maurer (j.m.maurer_at_student.utwente.nl)
Date: Thu Apr 22 2004 - 09:20:43 EDT
You're correct, I misread the patch. Looks great. Thank! Will commit
later today!
Marc
On Thu, 2004-04-22 at 15:15, Cooper, Mikey wrote:
> If just the top ruler is the only one that exists, it's easy, we just
> set the width of the top ruler to the width of the document view.
>
> If the left ruler also exists though, the width of the top ruler is the
> width of the document view + the width of the left ruler.
>
> Same is true of the left ruler's height if the top ruler exists.
>
> Mikey
>
> -----Original Message-----
> From: Marc Maurer [mailto:j.m.maurer_at_student.utwente.nl]
> Sent: Thursday, April 22, 2004 7:33 AM
> To: Mikey Cooper
> Cc: abiword-dev_at_abisource.com
> Subject: Re: Patch: Fix win32 ruler redraws during zoom down
>
>
> Why the "if ((f->getAPFrameData()->m_pTopRuler) &&
> (f->getAPFrameData()->m_pLeftRuler))" part? afaict, only the else clause
> is needed.
>
> Marc
>
>
> On Thu, 2004-04-22 at 10:38, Mikey Cooper wrote:
> > Disregard previous patch, this one won't crash when one ruler exists
> > and the other doesn't (for example, Normal view where there's no left
> ruler).
> >
> > Mikey
> >
> > ----- Original Message -----
> > From: "Mikey Cooper" <mikey_at_bluey.com>
> > To: <abiword-dev_at_abisource.com>
> > Sent: Thursday, April 22, 2004 2:44 AM
> > Subject: Patch: Fix win32 ruler redraws during zoom down
> >
> >
> > > The attached patch fixes a win32 issue where the rulers' views'
> > > heights
> > and
> > > widths don't get updated ever. It's most noticable when zooming
> > > from a large zoom like 300% to a lower one like 50%. Abi only
> > > redraws the ruler background up to getWidth() or getHeight(), so the
>
> > > right half or quarter
> > of
> > > the ruler was always remaining on the screen after a zoom-down.
> --
> Marc Maurer <j.m.maurer_at_student.utwente.nl>
>
-- Marc Maurer <j.m.maurer_at_student.utwente.nl>
This archive was generated by hypermail 2.1.4 : Thu Apr 22 2004 - 09:23:18 EDT