Re: patch for #4796

Hi Rob,

This patch is wrong. You strncpy wn.byteLength() and
not MIN(wn.byteLength(), width). So we're likely to
run into buffer overruns, which is bad.

Can you redo that part of the patch please?

Thanks,
Dom

--- Robert Staudinger <robsta@stereolyzer.net> wrote:

> Sorry, the patch seems to be somewhat mangeled,
> resending.
>
> On Tue, 2004-08-31 at 12:54, Robert Staudinger
> wrote:
> > Hello,
> >
> > this is a cleaned up patch for bug #4796. It fixes
> dialog titles for
> > documents containing non-ascii characters.
> >
> > I also changed the
> XAP_Dialog_Modeless::BuildWindowName signature
> > because the return value was never used and having
> pWindowName as
> > parameter AND return value is a little ambiguous
> IMHO.
> >
> > It would be really cool if you could look at it
> because it's been in CVS
> > for quite some time (2003-05-09).
> >
> > Thanks,
> > Rob
>

> ATTACHMENT part 2 application/octet-stream
name=bug#4796-1.diff

                
_______________________________
Do you Yahoo!?
Win 1 of 4,000 free domain names from Yahoo! Enter now.
http://promotions.yahoo.com/goldrush
Received on Tue Aug 31 13:44:16 2004