commit: Fix getProperties(), some Revsion mark bugs.

From: <msevior_at_physics.unimelb.edu.au>
Date: Wed Jul 21 2004 - 04:51:40 CEST

CVS: ----------------------------------------------------------------------
CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
CVS:
CVS: Committing in .
CVS:
CVS: Modified Files:
CVS: ptbl/xp/pp_AttrProp.cpp ptbl/xp/pp_AttrProp.h
CVS: ptbl/xp/pp_Revision.cpp ptbl/xp/pt_PieceTable.cpp
CVS: ----------------------------------------------------------------------
Fix getProperties insanity. Fix some other obvious revision mark bugs.

Previously the calling getProperties would overwrite a const
PP_PropertyType * pointer with a pointer of type const XML_Char *.

I have no idea why the author of this piece of code thought this would work.

The symptom was that any call to getProperties would return the correct
list of properties the first time. Subsequent calls would return rubbish
and was it had corrupted the property map data.

The main user of getProperties() was the revision mark code.

Now we actually build and cache an array of pointers to the properties.

In addition I fixed some other obvious bugs in Revision marks that jumped
out at me while testing this code.

It seems to work. uwog could you test this with your rv stuff?

Cheers

Martin
Received on Wed Jul 21 04:39:40 2004

This archive was generated by hypermail 2.1.8 : Wed Jul 21 2004 - 04:39:41 CEST