Re: Commit (STABLE): fix memory leaks

If you backported the plugin fixes, then things are
okay-ish. I've been hands-off for quite a while now,
but:

1) The API change in a stable series seems bad to me
2) I never liked Tomas' solution anyway, so I'm not
exactly fond of backporting it

Anyway, I'm appeased for the moment.
Dom

--- Mark Gilbert <mg_abimail@yahoo.com> wrote:
>
> I freaked out about this before you did. Didn't
> wanna go up against hub about the api, although
> it was wrong to me too, but I did backport all my
> plugin fixes for the change from head, including
> 6973.
> It would be trivial to back out the api change and
> my accomodations. I'll leave that call to you.
>
> -MG
>
> --- Dom Lachowicz <domlachowicz@yahoo.com> wrote:
> >
> > Hub,
> >
> > You do realize that you just broke half of the
> > plugins, right? And changed an API that probably
> > shouldn't be changed in a STABLE series,
> especially
> > since the memory-leak bugs aren't *that* serious?
> >
> > http://bugzilla.abisource.com/show_bug.cgi?id=6973
> > amongst others.
> >
> > Best regards,
> > Dom
> >
> > --- Hubert Figuiere <hfiguiere@teaser.fr> wrote:
> > >
> > > On Sat, 2004-04-24 at 10:08 +0100, Tomas
> Frydrych
> > > wrote:
> > > > fixed a number of memory leaks related to
> calling
> > > > FV_View::getSelectionText().
> > > >
> > > > I have changed the signature of the function
> from
> > > > ucs * getSelectionText()
> > > > to
> > > > void getSelectionText(ucs *&)
> > > >
> > > > This should reduce any future incorrect use
> (since
> > > it makes it
> > > > impossible to pass getSelectionText() directly
> as
> > > a function
> > > > parameter). I am not sure I have fixed up
> > > bindings/perl/AbiWord.cpp
> > > > correctly, if someone who understands and can
> > > compile that code could
> > > > verify that, it would be appreciated.
> > > >
> > > > This change might break some plugins.
> > > >
> > > > I have also added
> FV_View::getSelectionLength() as
> > > there was some
> > > > code that used getSelectionText() to ascertain
> the
> > > length of
> > > > selection.
> > > >
> > > > files: fv_View.h, fv_View_cmd.cpp,
> fv_View.cpp,
> > > > fl_SelectionPreserver.cpp, ap_EditMethods.cpp,
>
> > > > ap_Dialog_InsertHyperlink.cpp,
> > > ap_Win32Dialog_Replace.cpp,
> > > > bindinds/perl/AbiWord.cpp
> > > >
> > > > should be backported subject to verification
> of
> > > the perl bindings and
> > > > fixing up of plugins.
> > >
> > > Backporting this. At last.
> > >
> > > fixed a number of memory leaks related to
> calling
> > > FV_View::getSelectionText(). (backport tomas_f)
> > >
> > > CVS: Modified Files:
> > > CVS: Tag: ABI-2-0-0-STABLE
> > > CVS: src/bindings/perl/AbiWord.cpp
> > > CVS:
> src/text/fmt/xp/fl_SelectionPreserver.cpp
> > > CVS: src/text/fmt/xp/fv_View.cpp
> > > src/text/fmt/xp/fv_View.h
> > > CVS: src/text/fmt/xp/fv_View_cmd.cpp
> > > CVS: src/wp/ap/win/ap_Win32Dialog_Replace.cpp
> > > CVS:
> src/wp/ap/xp/ap_Dialog_InsertHyperlink.cpp
> > > CVS: src/wp/ap/xp/ap_EditMethods.cpp
> > >
> > > Hub
> > > --
> > > AbiWord maintainer -
> http://www.figuiere.net/hub/
> > >
> > >
> >
> >
> >
> >
> >
> > __________________________________
> > Do you Yahoo!?
> > Friends. Fun. Try the all-new Yahoo! Messenger.
> > http://messenger.yahoo.com/
>
>
>
>
>
> __________________________________
> Do you Yahoo!?
> Friends. Fun. Try the all-new Yahoo! Messenger.
> http://messenger.yahoo.com/

        
                
__________________________________
Do you Yahoo!?
Friends. Fun. Try the all-new Yahoo! Messenger.
http://messenger.yahoo.com/
Received on Sat Jun 12 06:17:30 2004