Commit (BOTH) Re: wv Patch: fix word import crashes

From: Marc Maurer (j.m.maurer_at_student.utwente.nl)
Date: Mon Mar 08 2004 - 15:17:32 EST

  • Next message: Marc Maurer: "Commit (STABLE): 2.0.4 -> 2.0.5"

    You are our hero for today! Commiting with dom's approval...

    Marc

    Fix wv's utter brokenness in stylesheet handling (Robert Wilhelm)
                                                                                    
    CVS:
    ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: Tag: ABI-2-0-0-STABLE
    CVS: stylesheet.c
    CVS:
    ----------------------------------------------------------------------
    CVS:
    ----------------------------------------------------------------------
    CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
    CVS:
    CVS: Committing in .
    CVS:
    CVS: Modified Files:
    CVS: stylesheet.c
    CVS:
    ----------------------------------------------------------------------

    Op ma 08-03-2004, om 21:00 schreef Robert Wilhelm:
    > Today I was able to trace the reason of all these "AbiWord 2.0.3"
    > crashes on Windows during import of Word dokument:
    >
    > The stylesheet.c patch which some unamed abi hacker commited on 1.1.2004
    > seems to be utterly broken:
    >
    > - b is initialized in every iteration of the loop.
    > - item->xstzName is used in strncat without initialising it.
    > - the terminating null is not taken into account when checking
    > if there is enough space
    > - the third argument to strncat is the maximum number of chars to be
    > concated, not the maximum result lenght.
    >
    > I have appended a patch.
    >
    > Robert 

    -- 
Marc Maurer <j.m.maurer_at_student.utwente.nl>

    This archive was generated by hypermail 2.1.4 : Mon Mar 08 2004 - 15:13:56 EST