Re: patch for #4796

This patch looks good and is approved for checkin.

Thanks,
Dom

--- Robert Staudinger <robsta@stereolyzer.net> wrote:

> Resending with added armor plating suggested by Dom.
> I used UT_MIN and also had to change the signature
> again to use
> UT_uint32 instead of UT_sint32 for the buffer size
> to avoid an integer
> comparison warning. UT_uint32 is what gets passed to
> the method anyways.
> Is that ok wrt to the recent mail about possible
> 64bit problems from
> Martin?
>
> Rob
>
> On Tue, 2004-08-31 at 13:58, Dom Lachowicz wrote:
> > Hi Rob,
> >
> > This patch is wrong. You strncpy wn.byteLength()
> and
> > not MIN(wn.byteLength(), width). So we're likely
> to
> > run into buffer overruns, which is bad.
> >
> > Can you redo that part of the patch please?
> >
> > Thanks,
> > Dom
> >
> > --- Robert Staudinger <robsta@stereolyzer.net>
> wrote:
> >
> > > Sorry, the patch seems to be somewhat mangeled,
> > > resending.
> > >
> > > On Tue, 2004-08-31 at 12:54, Robert Staudinger
> > > wrote:
> > > > Hello,
> > > >
> > > > this is a cleaned up patch for bug #4796. It
> fixes
> > > dialog titles for
> > > > documents containing non-ascii characters.
> > > >
> > > > I also changed the
> > > XAP_Dialog_Modeless::BuildWindowName signature
> > > > because the return value was never used and
> having
> > > pWindowName as
> > > > parameter AND return value is a little
> ambiguous
> > > IMHO.
> > > >
> > > > It would be really cool if you could look at
> it
> > > because it's been in CVS
> > > > for quite some time (2003-05-09).
> > > >
> > > > Thanks,
> > > > Rob
> > >
> >
> > > ATTACHMENT part 2 application/octet-stream
> > name=bug#4796-1.diff
> >
> >
> >
> >
> >
> > _______________________________
> > Do you Yahoo!?
> > Win 1 of 4,000 free domain names from Yahoo! Enter
> now.
> > http://promotions.yahoo.com/goldrush
> >
>

> ATTACHMENT part 2 application/octet-stream
name=bug#4796-2.diff

                
_______________________________
Do you Yahoo!?
Win 1 of 4,000 free domain names from Yahoo! Enter now.
http://promotions.yahoo.com/goldrush
Received on Wed Sep 1 05:40:33 2004