Re: patch for #4293

Ok, this is a somewhat more courageous version of the patch wrt to
changing things.

>
> Some questions about this patch:
>
> 1) Why use len instead of sizeof(buf) - 1?
>
> 2) Why use sprintf() instead of g_snprintf()?
> 2.a) Why use sprintf() when you're actually just doing
> a strcpy()?

This stuff is not required at all any more

> 3) Why did you put the asterisk ("*") before the
> title? Every other app always has it after the title.

I left this out, until clarified on the usability list.

> 4) Does UT_basename() return a pointer within the
> szName buffer, a UT_UTF8String object, or
> newly-allocated memory? If the latter, it needs to be
> free'd. If either of the former, use the UT_UTF8String
> copy constructor.

It's the former, constructor is used now.

Thanks for feedback,
Rob

> Dom
>
> --- Robert Staudinger <robsta@stereolyzer.net> wrote:
>
> > Hello,
> >
> > the attached patch fixes #4293 "title of window
> > should be just filename,
> > not full path".
> >
> > The only remaining thing is that
> > XAP_STRING_ID_UntitledDocument should
> > be "Untitled Document" instead of just "Untitled".
> > Didn't find it until
> > now.
> >
> > Rob
> >
>
> > ATTACHMENT part 2 application/octet-stream
> name=bug#4293.diff
>
>
>
>
>
> __________________________________
> Do you Yahoo!?
> Read only the mail you want - Yahoo! Mail SpamGuard.
> http://promotions.yahoo.com/new_mail