Re: RTF importer mods (PATCH)

Both patches look correct. #8001 is obviously correct.

review +dom

Thanks Roland.

--- Roland Kay <roland.kay@ox.compsoc.net> wrote:
>
>
>
> Hi guys,
>
> #8813:
> I've just submitted some more modifications to the
> RTF
> importer on bugzilla[1]. These add support for the
> \deff
> keyword and fix a problem with the importers
> handling of
> multiple characters sets in a single document
> (something
> that MSWord exported documents in Asia contain a lot
> of).
>
> #8001:
> I've also posted the patch[2] from my last email
> which
> addresses the clipboard issue.
>
> While doing this I noticed what looks suspiciously
> like a
> missing break in a select construct. See line 4124
> in the
> patched version of
> abi/src/wp/impexp/xp/ie_imp_RTF.cpp.
> I've commented it in the patch, would someone mind
> having a
> look? Before the patch the case for the "clcbpat"
> command
> was falling through to the handler for the "dn".
> With the
> patch it falls through to the "deff" handler. I
> assume both
> are incorrect?
>
> [1]
> http://bugzilla.abisource.com/show_bug.cgi?id=8813
> [2]
> http://bugzilla.abisource.com/show_bug.cgi?id=8001
>
> Best wishes,
>
> R.
>
>
>

                
__________________________________
Discover Yahoo!
Have fun online with music videos, cool games, IM and more. Check it out!
http://discover.yahoo.com/online.html
Received on Wed Jun 1 02:48:15 2005