Re: Abiword in Maemo plataform

>
> On 6/17/05, Hubert Figuiere <hfiguiere@teaser.fr> wrote:
>> Robert Staudinger wrote:
>> >
>> > I don't want to be the whiner but ...
>> >
>> > The patch contains quite a big number of #ifdefs. I think that's not
>> > such a big problem in the UnixDialog classes (they are rather
>> > isolated) but the App, Menu, Frame and Toolbar stuff is much more at
>> > the core of the software. E.g. the application class structure has
>> > been split into App and AppImpl in the past (i think by Will
>> > Lachance). From only quickly looking over the patch it seems quite
>> > suited to leverage this "engineered" design, rather than resort to
>> > #ifdefs all over the place. In short, what do people think about
>> > implementing the hildon stuff using an own AppImpl and eventually
>> > FrameImpl?
>>
>> The problem is that it is a variant of the Gtk platform. Lot of stuff is
>> done the same way, and it does not make sense to split that off.
>
> That's the same as UnixToolbar and GnomeToolbar, the latter
> subclassing the further. The same could be done with AppImpl i think.
> Only af few hooks implement the extra functionality. IMO that's
> cleaner.
>
> But well, if all of you are happy i'll shut up.

I believe that Rob has a point. It would be better to subclass where
appropriate. However I still think the patch should go in now. We can fix
those after the patch is in.

It would be easiest for everyone if we concentrate on CVS HEAD. The patch
is basically self contained, not harmful and does not drain other
developers time.

Maybe we could even lure wlach to do the sub-classing? (Hint, Hint Will :-)

Cheers

Martin

>
> - Rob
>
Received on Sat Jun 18 01:20:32 2005